Details
Diff Detail
- Repository
- rZORG LLVM Github Zorg
- Build Status
Buildable 91330 Build 126900: arc lint + arc unit
Event Timeline
Looks good with a couple nit picks.
Please see my comments in line.
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
1496 | Having a particular version of clang in the builder name looks too restrictive for future changes. You might want to change that to 12 in 6 months or so. | |
1513 | How about using variants or specify a link to a particular clang version, so you could update the clang on the worker without changing the builders.py when you will want to use more recent version in the future? |
Change clang version to 10 since that one is the newest one
available for bionic (which we use for workers).
Thanks for the review @gkistanova !
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
1513 | How does this look? My plan is on the worker side to have this point to the latest version of clang. |
@stevanradakovic , thank you for adding this!
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
1495 | I think that adding aarch64 here (and perhaps release) would help navigating http://lab.llvm.org:8011/. | |
1512 | IIUC, Release is the default, see here. Personally I prefer being explicit, so this is just as an FYI :) |
I think that adding aarch64 here (and perhaps release) would help navigating http://lab.llvm.org:8011/.