This is an archive of the discontinued LLVM Phabricator instance.

Differential D97270

Add buildbot for Clang for XCore target on Ubuntu host.
ClosedPublic

Authored by nigelp-xmos on Feb 23 2021, 4:12 AM.

Details

Reviewers
gkistanova

Diff Detail

Event Timeline

nigelp-xmos created this revision.Feb 23 2021, 4:12 AM
Herald added a reviewer: gkistanova. · View Herald TranscriptFeb 23 2021, 4:12 AM
nigelp-xmos requested review of this revision.Feb 23 2021, 4:12 AM
Harbormaster completed remote builds in B90371: Diff 325737.Feb 23 2021, 4:12 AM
gkistanova accepted this revision.Mar 2 2021, 7:37 PM

It is good with a couple of small things to address.

Please feel free to commit with the changes.

buildbot/osuosl/master/config/builders.py
829

No need to specify the LLVM_ENABLE_PROJECTS, unless this is something really special. The factory will take care of this based on the list of dependent projects and given build factory arguments.

830

No need in extra quotation marks. Specifying the list like "-DLLVM_LIT_ARGS:STRING=--xunit-xml-output xunit.xml -sv" is fine.

This revision is now accepted and ready to land.Mar 2 2021, 7:37 PM
nigelp-xmos updated this revision to Diff 327728.Mar 3 2021, 2:41 AM

Revise as per review comments.

Harbormaster completed remote builds in B91773: Diff 327728.Mar 3 2021, 2:41 AM
nigelp-xmos marked 2 inline comments as done.Mar 3 2021, 2:41 AM
nigelp-xmos closed this revision.Mar 3 2021, 2:55 AM

https://github.com/llvm/llvm-zorg/commit/f128ee547d9f4d1fc9480b9e95b6c119d9a08392

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
3 lines

Diff 327728

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 820 Lines • ▼ Show 20 Lines 'factory' : ClangBuilder.getClangCMakeBuildFactory(
test=True, test=True,
testStage1=True, testStage1=True,
useTwoStage=False, useTwoStage=False,
stage1_config='Release', stage1_config='Release',
extra_cmake_args=[ extra_cmake_args=[
"-DLLVM_TARGETS_TO_BUILD:STRING=XCore", "-DLLVM_TARGETS_TO_BUILD:STRING=XCore",
"-DLLVM_DEFAULT_TARGET_TRIPLE:STRING=xcore-unknown-unknown-elf", "-DLLVM_DEFAULT_TARGET_TRIPLE:STRING=xcore-unknown-unknown-elf",
"-DLLVM_ENABLE_THREADS:BOOL=OFF", "-DLLVM_ENABLE_THREADS:BOOL=OFF",
"-DLLVM_ENABLE_PROJECTS:STRING=clang", "-DLLVM_LIT_ARGS:STRING=--xunit-xml-output xunit.xml -sv"])},
gkistanovaUnsubmitted
Done
ReplyInline Actions

No need to specify the LLVM_ENABLE_PROJECTS, unless this is something really special. The factory will take care of this based on the list of dependent projects and given build factory arguments.

gkistanova: No need to specify the `LLVM_ENABLE_PROJECTS`, unless this is something really special. The…
"-DLLVM_LIT_ARGS:STRING='--xunit-xml-output xunit.xml -sv'"])},
gkistanovaUnsubmitted
Done
ReplyInline Actions

No need in extra quotation marks. Specifying the list like "-DLLVM_LIT_ARGS:STRING=--xunit-xml-output xunit.xml -sv" is fine.

gkistanova: No need in extra quotation marks. Specifying the list like "-DLLVM_LIT_ARGS:STRING=--xunit-xml…
# Polly builders. # Polly builders.
{'name' : "polly-arm-linux", {'name' : "polly-arm-linux",
'tags' : ["polly"], 'tags' : ["polly"],
'workernames' : ["hexagon-build-02", "hexagon-build-03"], 'workernames' : ["hexagon-build-02", "hexagon-build-03"],
'builddir': "polly-arm-linux", 'builddir': "polly-arm-linux",
'factory' : PollyBuilder.getPollyBuildFactory( 'factory' : PollyBuilder.getPollyBuildFactory(
clean=True, clean=True,
▲ Show 20 Lines • Show All 964 Lines • Show Last 20 Lines