- User Since
- Mar 24 2020, 8:40 AM (56 w, 1 d)
@echristo Thanks for the comment, Eric. I'm happy to do what is expected. Do you mean that it's a bug not to accept these cases, and we should fix it rather than XFAIL? So the build should not be green from XFAIL but only from a fix in this case?
Tue, Apr 20
In a quick test, I used else if (TI.getTypeWidth(TI.getWCharType()) == 8) but did you want to avoid that?
At the moment Clang defines __XS1B__ for XCore, but really that's one subtarget, I need to patch to define __xcore__ . It's an embedded processor, usually bare metal, so wouldn't have an OS character set. I just saw this change and thought I'd mention it's only 8 bits wide - I don't know what the best approach is. I'll discuss with others. Thanks for the quick reply.
The XCore target has 8-bit wchar_t (unsigned char). Should there be a test for width == 8 and set to "UTF-8", or at least not "UTF-16"?
Invite inline assembly code owner to review.
Mon, Apr 19
Fri, Apr 16
Thank you for the reviews, I appreciate people taking time on something that is only for this target.
Thu, Apr 15
Invite debug info code owner to review.
Mon, Apr 12
As suggested, excluded xcore from DebugInfo/Generic rather than patching each file.
Thu, Apr 1
Restore lit feature object-emission. Omit DebugInfo/Generic on XCore.
Wed, Mar 31
Thanks, I see what you mean about churn and maintenance. The integrated assembler is planned. I will rework the patch.
DebugInfo/Generic can be handled by two lines in lit.local.cfg:
@MaskRay Thanks for the comment. I will look at that. But DebugInfo/Generic has 78 files requiring object-emission and 60 not requiring it - isn't it worth still running the 60? (I looked at some to see what they were doing: running llvm-as, llvm-dis, and checking assembly output.)
Tue, Mar 30
Invite reviewers around llvm-mc tool tests.
Invite reviewers around llvm-mc tool tests.
Invite reviewers around lit.cfg.py changes.
Wed, Mar 24
Mar 23 2021
Mar 22 2021
Mar 19 2021
Mar 18 2021
Add reviewer suggestions from CodeGen/Generic history.
Mar 13 2021
Mar 12 2021
Mar 11 2021
- Incorporate isConfigurationSupported in isObjectEmissionSupported
@labath Thanks for the quick response. That looks like a good idea. I will try that.
Mar 10 2021
Mar 8 2021
arc --update with all changes.
[XCore] Do not override LLVM_LIT_ARGS: use -j from the factory.
Mar 4 2021
Mar 3 2021
Revise as per review comments.
Feb 23 2021
Jan 14 2021
Jan 9 2021
I think this patch can be cancelled, because the issue is already fixed in the main branch. But please say if I have missed something.
Jan 5 2021
I've reproduced the failure. The test passes when I change -march=xcore to -mtriple=xcore-unknown-unknown, as in main branch commit https://github.com/llvm/llvm-project/commit/15ca54525d6c2927b2a51b871a9e343c7ce1c2ea. Does that commit solve this problem and unblock D91556 ? (I will continue to investigate to understand the reason for the register swap.)
Jan 4 2021
The specified XCore backend code owner has moved on from XMOS and from working on XCore. I will have a look at this patch.
Dec 8 2020
Many thanks for review and approval. Please could it be committed as I do not have commit access? (I will request.)
Added reviewer suggestions from git history. If someone familiar with updating the documentation could commit for me, I would be grateful, as I do not have commit access.
Nov 25 2020
Alternatively, if all 1-byte-character strings are acceptable, should I remove the check that the first token is a string literal, and omit the failing test case on XCore?
Nov 24 2020
Jun 24 2020
I do not have commit access, so if this is approved, please could it be committed against author "Nigel Perks" email@example.com ?
Added explanatory comment and CHECK lines to test case, as per review comment.
Jun 22 2020
Ping. I made the change suggested by @erichkeane .
May 28 2020
May 19 2020
As suggested by FIXME comment in code, and review comment, moved the EmitTargetMetadata loop into XCore target.
May 12 2020
Thanks for the comment, I will look into that.
Adding code reviewer suggestions from git history. I would be grateful for review and/or reviewer suggestions. Many thanks.
Apr 27 2020
This patches fixes two Clang tests which are failing for XCore target on 2020-04-27 with "unexpected null value" assert failures:
Apr 15 2020
Just a polite ping to keep it alive. I hope that's all right. Not urgent at all.