This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] libomp: Add masked construct, change proc-bind keyword, deprecate master construct
ClosedPublic

Authored by tlwilmar on Feb 18 2021, 7:28 PM.

Details

Summary

Added API for "masked" construct via two entrypoints: kmpc_masked, and kmpc_end_masked. The "master" construct is deprecated. Changed proc-bind keyword from "master" to "primary". Use of both master construct and master as proc-bind keyword is still allowed, but deprecated.

Remove references to "master" in comments and strings, and replace with "primary" or "primary thread". Function names and variables were not touched, nor were references to deprecated master construct. These can be updated over time. No new code should refer to master.

Diff Detail

Repository
rOMP OpenMP

Event Timeline

tlwilmar created this revision.Feb 18 2021, 7:28 PM
tlwilmar requested review of this revision.Feb 18 2021, 7:28 PM
jlpeyton added inline comments.Feb 25 2021, 12:15 PM
openmp/runtime/src/kmp.h
1455

The corresponding string "\"masked\"" should be put into cons_text_c in kmp_error_cpp

tlwilmar updated this revision to Diff 326854.Feb 26 2021, 5:34 PM

Added masked to cons_text_c.

This revision is now accepted and ready to land.Mar 1 2021, 10:16 AM

Hi Johnny,
When I just commit via the instructions on our wiki, I just see this separate e-mail labeled "[Diffusion]" which looks like a separate review in Phabricator. When others push their changes, it appears attached to the original phabricator review, and seems to close it automagically. What am I missing there?

Thanks!

Hi Johnny,
When I just commit via the instructions on our wiki, I just see this separate e-mail labeled "[Diffusion]" which looks like a separate review in Phabricator. When others push their changes, it appears attached to the original phabricator review, and seems to close it automagically. What am I missing there?

Thanks!

Ah, you have to include the line:
Differential Revision: https://reviews.llvm.org/D97019
in the commit message. This line is used to attach the commit to the Phabricator review.

@tlwilmar , you can just close this revision manually, but if you look at the git log for the llvm-project you'll see the "Differential Revision: <hyperlink>" line in many of the commits.

tlwilmar closed this revision.Mar 5 2021, 12:47 PM