Page MenuHomePhabricator

[NFC] update LangRef for D88645
Needs RevisionPublic

Authored by Tyker on Sat, Feb 13, 4:28 AM.

Details

Diff Detail

Event Timeline

Tyker requested review of this revision.Sat, Feb 13, 4:28 AM
Tyker created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSat, Feb 13, 4:28 AM

The text needs an update too. It talks about each argument but not the new one. Also, " and the last argument is the line number." is now clearly wrong.

Tyker updated this revision to Diff 323788.Mon, Feb 15, 10:14 AM

addressed comment

andrew.w.kaylor added inline comments.
llvm/docs/LangRef.rst
19804–19805

This 'and' becomes redundant with the additional text.

19805

Can you add some information about what the additional arguments are? What exactly does this point to?

Tyker updated this revision to Diff 325715.Tue, Feb 23, 1:55 AM

fixed the sentence.

Can you add some information about what the additional arguments are? What exactly does this point to?

This is not clear from the description.

Tyker updated this revision to Diff 327088.Mon, Mar 1, 5:52 AM

added more details about the storage of additional arguments.

I'm not trying to be difficult, but I genuinely still don't understand the additional arguments pointer. Is it intended to allow proprietary extensions? Is there an example somewhere?

If these intrinsics are meant as a general mechanism to enable arbitrary communication between custom front ends and custom optimization passes, that's fine. I'd just like to see something explicitly explaining that.

lebedev.ri requested changes to this revision.Mon, Mar 1, 10:43 AM
lebedev.ri added a subscriber: lebedev.ri.

This patch is missing a description.

This revision now requires changes to proceed.Mon, Mar 1, 10:43 AM