Page MenuHomePhabricator
Differential D96646

[NFC] update LangRef for D88645
Needs RevisionPublic
Actions

Authored by Tyker on Sat, Feb 13, 4:28 AM.

Details

Reviewers
jdoerfert
lebedev.ri

Diff Detail

Event Timeline

Tyker requested review of this revision.Sat, Feb 13, 4:28 AM
Tyker created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSat, Feb 13, 4:28 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Tyker mentioned this in D88645: [Annotation] Allows annotation to carry some additional constant arguments..Sat, Feb 13, 4:29 AM
Harbormaster completed remote builds in B89106: Diff 323546.Sat, Feb 13, 5:29 AM
jdoerfert added a comment.Sat, Feb 13, 2:32 PM

The text needs an update too. It talks about each argument but not the new one. Also, " and the last argument is the line number." is now clearly wrong.

Tyker updated this revision to Diff 323788.Mon, Feb 15, 10:14 AM

addressed comment

Harbormaster completed remote builds in B89258: Diff 323788.Mon, Feb 15, 11:30 AM
andrew.w.kaylor added a subscriber: andrew.w.kaylor.Tue, Feb 16, 10:49 AM
andrew.w.kaylor added inline comments.
llvm/docs/LangRef.rst
19804–19805

This 'and' becomes redundant with the additional text.

19805

Can you add some information about what the additional arguments are? What exactly does this point to?

andrew.w.kaylor mentioned this in D95993: Add auto-upgrade support for annotation intrinsics.Mon, Feb 22, 1:06 PM
Tyker updated this revision to Diff 325715.Tue, Feb 23, 1:55 AM

fixed the sentence.

Harbormaster completed remote builds in B90360: Diff 325715.Tue, Feb 23, 2:59 AM
jdoerfert added a comment.Tue, Feb 23, 8:22 AM

Can you add some information about what the additional arguments are? What exactly does this point to?

This is not clear from the description.

tstellar added a subscriber: tstellar.Tue, Feb 23, 11:14 AM
Tyker updated this revision to Diff 327088.Mon, Mar 1, 5:52 AM

added more details about the storage of additional arguments.

Harbormaster completed remote builds in B91319: Diff 327088.Mon, Mar 1, 7:02 AM
andrew.w.kaylor added a comment.Mon, Mar 1, 10:38 AM

I'm not trying to be difficult, but I genuinely still don't understand the additional arguments pointer. Is it intended to allow proprietary extensions? Is there an example somewhere?

If these intrinsics are meant as a general mechanism to enable arbitrary communication between custom front ends and custom optimization passes, that's fine. I'd just like to see something explicitly explaining that.

lebedev.ri requested changes to this revision.Mon, Mar 1, 10:43 AM
lebedev.ri added a subscriber: lebedev.ri.

This patch is missing a description.

This revision now requires changes to proceed.Mon, Mar 1, 10:43 AM

Revision Contents
Changeset List

PathSize
llvm/
docs/
20 lines

Diff 327088

View Options

llvm/docs/LangRef.rst

Loading...