This is an archive of the discontinued LLVM Phabricator instance.

Fix MergeConsecutiveStore for non-byte-sized memory accesses.
ClosedPublic

Authored by jyknight on May 8 2015, 3:43 PM.

Details

Summary

This bug showed up as a compiler bug building msan tests on x86-64.

Prior to r236850, this bug was masked due to a bogus alignment check,
which also accidentally rejected non-byte-sized accesses.

It would probably be a good idea to handle merging stores of this kind
as well, but for now, to un-break it, make the minimal fix.

Diff Detail

Event Timeline

jyknight updated this revision to Diff 25377.May 8 2015, 3:43 PM
jyknight retitled this revision from to Fix MergeConsecutiveStore for non-byte-sized memory accesses..
jyknight updated this object.
jyknight edited the test plan for this revision. (Show Details)
jyknight added a subscriber: Unknown Object (MLST).

I'm going to submit this now despite no review yet, since it's small, seems a clear bugfix, and seems a good idea not to leave broken until Monday.

This revision was automatically updated to reflect the committed changes.