This is an archive of the discontinued LLVM Phabricator instance.

New AST matcher: gnuNullExpr
ClosedPublic

Authored by eszasip on May 7 2015, 4:04 AM.

Details

Reviewers
klimek
Summary

Adding a new AST matcher that matches GNU __null expression.

Diff Detail

Event Timeline

eszasip updated this revision to Diff 25156.May 7 2015, 4:04 AM
eszasip retitled this revision from to New AST matcher: gnuNullExpr.
eszasip updated this object.
eszasip edited the test plan for this revision. (Show Details)
eszasip added a reviewer: alexfh.
eszasip added a subscriber: Unknown Object (MLST).
alexfh edited reviewers, added: klimek; removed: alexfh.May 7 2015, 4:07 AM
alexfh removed a subscriber: klimek.
alexfh added a subscriber: alexfh.

Manuel is a better reviewer for this. He'll probably want some tests for the new matcher.

klimek edited edge metadata.May 7 2015, 4:13 AM

+1, a test would be awesome - look at how we test other declarative node matchers...

eszasip updated this revision to Diff 25172.May 7 2015, 6:08 AM
eszasip edited edge metadata.

Added test for the matcher.

klimek accepted this revision.May 7 2015, 6:40 AM
klimek edited edge metadata.

lg

This revision is now accepted and ready to land.May 7 2015, 6:40 AM
eszasip closed this revision.May 7 2015, 7:33 AM

Committed in r236731.

lg

Thanks.