This is an archive of the discontinued LLVM Phabricator instance.

Differential D9436

Addition of 'sparcel' in one more place
ClosedPublic

Authored by dougk on May 1 2015, 9:12 AM.

Details

Reviewers
jyknight
venkatra
rnk
Commits
rG49e96132ceb5: Fix omission from adding sparcel (original http://reviews.llvm.org/D9263)
rL236322: Fix omission from adding sparcel (original http://reviews.llvm.org/D9263)
Summary

Failed to add it to getArchTypeForLLVMName and mysteriously nothing broke.
This is just the minimal change to get 'llvm-mc' not to have brain-damaged behavior for certain combinations of arguments.

Diff Detail

Repository
rL LLVM

Event Timeline

dougk updated this revision to Diff 24808.May 1 2015, 9:12 AM
dougk retitled this revision from to Addition of 'sparcel' in one more place.
dougk updated this object.
dougk edited the test plan for this revision. (Show Details)
dougk added reviewers: jyknight, venkatra.
dougk added a subscriber: Unknown Object (MLST).
rnk accepted this revision.May 1 2015, 9:29 AM
rnk added a reviewer: rnk.
rnk added a subscriber: rnk.

lgtm

I'm sure we'll have dedicated codegen tests in the future relying on this functionality, so I'm not too worried about it.

This revision is now accepted and ready to land.May 1 2015, 9:29 AM
Closed by commit rL236322: Fix omission from adding sparcel (original http://reviews.llvm.org/D9263) (authored by dougk). · Explain WhyMay 1 2015, 9:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Support/
1 line

Diff 24816

llvm/trunk/lib/Support/Triple.cpp

Show First 20 Lines • Show All 206 Lines • ▼ Show 20 Lines return StringSwitch<Triple::ArchType>(Name)
.Case("ppc64", ppc64) .Case("ppc64", ppc64)
.Case("ppc32", ppc) .Case("ppc32", ppc)
.Case("ppc", ppc) .Case("ppc", ppc)
.Case("ppc64le", ppc64le) .Case("ppc64le", ppc64le)
.Case("r600", r600) .Case("r600", r600)
.Case("amdgcn", amdgcn) .Case("amdgcn", amdgcn)
.Case("hexagon", hexagon) .Case("hexagon", hexagon)
.Case("sparc", sparc) .Case("sparc", sparc)
.Case("sparcel", sparcel)
.Case("sparcv9", sparcv9) .Case("sparcv9", sparcv9)
.Case("systemz", systemz) .Case("systemz", systemz)
.Case("tce", tce) .Case("tce", tce)
.Case("thumb", thumb) .Case("thumb", thumb)
.Case("thumbeb", thumbeb) .Case("thumbeb", thumbeb)
.Case("x86", x86) .Case("x86", x86)
.Case("x86-64", x86_64) .Case("x86-64", x86_64)
.Case("xcore", xcore) .Case("xcore", xcore)
▲ Show 20 Lines • Show All 935 Lines • Show Last 20 Lines