Page MenuHomePhabricator

[lld-macho] Associate each Symbol with an InputFile
Needs ReviewPublic

Authored by int3 on Fri, Jan 8, 9:01 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This makes our error messages more informative. But the bigger motivation is for
LTO symbol resolution, which will be in an upcoming diff. The changes in this
one are largely mechanical.

Diff Detail

Event Timeline

int3 requested review of this revision.Fri, Jan 8, 9:01 AM
int3 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jan 8, 9:01 AM
int3 updated this revision to Diff 315441.Fri, Jan 8, 10:22 AM

minor update

compnerd added inline comments.
lld/MachO/Symbols.h
202

Why not just cast<DylibFile>(file)? It will preserve the assertion and have the same behaviour.

217

Similar

int3 updated this revision to Diff 316179.Tue, Jan 12, 11:42 AM

use cast<>