Page MenuHomePhabricator
Differential D94316

[lld-macho] Associate each Symbol with an InputFile
Needs ReviewPublic
Actions

Authored by int3 on Fri, Jan 8, 9:01 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This makes our error messages more informative. But the bigger motivation is for
LTO symbol resolution, which will be in an upcoming diff. The changes in this
one are largely mechanical.

Diff Detail

Event Timeline

int3 requested review of this revision.Fri, Jan 8, 9:01 AM
int3 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jan 8, 9:01 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B84483: Diff 315419.Fri, Jan 8, 9:31 AM
int3 updated this revision to Diff 315441.Fri, Jan 8, 10:22 AM

minor update

Harbormaster completed remote builds in B84492: Diff 315441.Fri, Jan 8, 10:52 AM
int3 added a child revision: D94342: [lld-macho] Basic support for linkage and visibility attributes in LTO.Fri, Jan 8, 2:28 PM
compnerd added a subscriber: compnerd.Mon, Jan 11, 1:56 PM
compnerd added inline comments.
lld/MachO/Symbols.h
202

Why not just cast<DylibFile>(file)? It will preserve the assertion and have the same behaviour.

217

Similar

int3 updated this revision to Diff 316179.Tue, Jan 12, 11:42 AM

use cast<>

Harbormaster completed remote builds in B84887: Diff 316179.Tue, Jan 12, 12:13 PM

Revision Contents
Changeset List

PathSize
lld/
MachO/
8 lines
2 lines
18 lines
10 lines
29 lines
40 lines
2 lines
25 lines
7 lines
test/
MachO/
invalid/
4 lines
8 lines

Diff 316179

View Options

lld/MachO/Driver.cpp

Loading...
View Options

lld/MachO/ExportTrie.cpp

Loading...
View Options

lld/MachO/InputFiles.cpp

Loading...
View Options

lld/MachO/SymbolTable.h

Loading...
View Options

lld/MachO/SymbolTable.cpp

Loading...
View Options

lld/MachO/Symbols.h

Loading...
View Options

lld/MachO/Symbols.cpp

Loading...
View Options

lld/MachO/SyntheticSections.cpp

Loading...
View Options

lld/MachO/Writer.cpp

Loading...
View Options

lld/test/MachO/invalid/abs-duplicate.s

Loading...
View Options

lld/test/MachO/invalid/duplicate-symbol.s

Loading...