This is an archive of the discontinued LLVM Phabricator instance.

[simd_ops] Build tests with -fpic
ClosedPublic

Authored by ostannard on Jan 5 2021, 6:22 AM.

Details

Reviewers
MaskRay
asbirlea
Summary

Since https://reviews.llvm.org/rG2047c10c22b0, the dso_local specifier
must be included in IR when building non-PIC code. The bitcode files in
this test suite do not have this, so will only work when all of the code
is built with -fpic.

The alternative to this would be to re-generate the bitcode with the
dso_local specifier where needed, but I don't know how this code was
generated in the first place, and don't want to modify the bitcode files
in-place if they might be later re-generated.

Diff Detail

Event Timeline

ostannard created this revision.Jan 5 2021, 6:22 AM
ostannard requested review of this revision.Jan 5 2021, 6:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 6:22 AM
MaskRay accepted this revision.Jan 5 2021, 10:05 AM

We may have to reinstate the dso_local specifier for ELF definitions it it turns out to be widespread issues, but adding this LG.

This revision is now accepted and ready to land.Jan 5 2021, 10:05 AM

I'll look into regenerating the bitcode files, but in the mean time this looks good.

asbirlea accepted this revision.Jan 5 2021, 10:13 AM