This is an archive of the discontinued LLVM Phabricator instance.

[VE] Remove -faddrsig and -fnoaddrsig tests
ClosedPublic

Authored by kaz7 on Dec 9 2020, 8:51 PM.

Details

Summary

Remove explicitly declared -faddrsig and -fnoaddrsig option tests
since those are already tested in addrsig.c. We test only the implicit
behavior of VE driver.

This is suggested in https://reviews.llvm.org/D92386. Thanks.

Diff Detail

Event Timeline

kaz7 requested review of this revision.Dec 9 2020, 8:51 PM
kaz7 created this revision.
MaskRay added inline comments.Dec 9 2020, 10:58 PM
clang/test/Driver/ve-toolchain.cpp
72

Most newer toolchains default to -fuse-init-array. There is probably very little value testing -f[no-]use-init-array

112

Such tests should use --sysroot and a fake tree (see Inputs/basic_*_tree), otherwise clang may find the toolchain under /usr

kaz7 added a comment.Dec 10 2020, 12:47 AM

Thank you for additional suggestions. I'll make next patch like "optimize ve-toolchain.c and .cpp." Thank you so much!

clang/test/Driver/ve-toolchain.cpp
72

That's make sense. I'll remove that in next patch.

112

Thanks! I'll try to add that one too in next patch.

MaskRay accepted this revision.Dec 10 2020, 12:30 PM

LGTM.

This revision is now accepted and ready to land.Dec 10 2020, 12:30 PM
kaz7 added a comment.Dec 10 2020, 3:24 PM

Thanks! Working on sysroot stuff now. :-)

This revision was landed with ongoing or failed builds.Dec 10 2020, 3:25 PM
This revision was automatically updated to reflect the committed changes.