This is an archive of the discontinued LLVM Phabricator instance.

Fix condition detection in EmulateInstructionARM
ClosedPublic

Authored by tberghammer on Apr 23 2015, 5:46 AM.

Details

Summary

Fix condition detection in EmulateInstructionARM

The condition detection code is calculating the result of the condition
based on the first 3 bit of the condition and then negate it if the LSB
of the condition is set. It works for the normal conditions but 0b1110
and 0b1111 are special as both of them should evaluate to true
independently the value of CPSR. This CL removes the negating logic from
those cases.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Fix condition detection in EmulateInstructionARM.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added reviewers: sas, clayborg.
tberghammer added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Apr 23 2015, 9:43 AM
clayborg edited edge metadata.

Looks fine.

This revision is now accepted and ready to land.Apr 23 2015, 9:43 AM
This revision was automatically updated to reflect the committed changes.