This is an archive of the discontinued LLVM Phabricator instance.

Move DIContext.h to a common level
ClosedPublic

Authored by zturner on Apr 22 2015, 12:59 PM.

Details

Summary

DIContext.h contains some DebugInfo related classes that are not specified to any particular type of debug information. llvm-symbolizer makes use of these classes, so in order to extend llvm-symbolizer to support PDB it is necessary for DebugInfoPDB to have access to this file so that it can subclass DIContext to make a PDBContext class. This patch moves DIContext up a level, but does not yet provide an implementation of PDBContext.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner updated this revision to Diff 24252.Apr 22 2015, 12:59 PM
zturner retitled this revision from to Move DIContext.h to a common level.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added reviewers: echristo, dblaikie, samsonov.
zturner added a subscriber: Unknown Object (MLST).
samsonov accepted this revision.Apr 22 2015, 1:29 PM
samsonov edited edge metadata.

LGTM

lib/DebugInfo/DWARF/DWARFUnit.cpp
259 ↗(On Diff #24252)

I don't think this cast is now necessary.

This revision is now accepted and ready to land.Apr 22 2015, 1:29 PM
This revision was automatically updated to reflect the committed changes.
llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h