This is an archive of the discontinued LLVM Phabricator instance.

Differential D9119

Add Makefile for typedef_array -Makefile was deleted by r235313 causing test failure of TestTypedefArray.py, add it back
ClosedPublic

Authored by chying on Apr 20 2015, 11:54 AM.

Details

Reviewers
chaoren
sivachandra
vharron
Commits
rG1ff46f2060c7: Add Makefile for typedef_array
rLLDB235346: Add Makefile for typedef_array
rL235346: Add Makefile for typedef_array
Summary

-Makefile was deleted by r235313 causing test failure of TestTypedefArray.py, add it back

Diff Detail

Repository
rL LLVM

Event Timeline

chying updated this revision to Diff 24041.Apr 20 2015, 11:54 AM
chying retitled this revision from to Add Makefile for typedef_array -Makefile was deleted by r235313 causing test failure of TestTypedefArray.py, add it back.
chying updated this object.
chying edited the test plan for this revision. (Show Details)
chying added reviewers: chaoren, sivachandra, vharron.
chying added a subscriber: Unknown Object (MLST).
sivachandra accepted this revision.Apr 20 2015, 1:24 PM
sivachandra edited edge metadata.

Wonder why only this Makefile toggles.

This revision is now accepted and ready to land.Apr 20 2015, 1:24 PM
Closed by commit rL235346: Add Makefile for typedef_array (authored by chying). · Explain WhyApr 20 2015, 1:37 PM
This revision was automatically updated to reflect the committed changes.
chying added a comment.Apr 20 2015, 1:45 PM
In D9119#158547, @sivachandra wrote:

Wonder why only this Makefile toggles.

Checked with the author of r235313, and he confirmed the change was made unintentionally.

sivachandra added a comment.Apr 20 2015, 1:55 PM

What I mean is this:

$ git log -p -- ./functionalities/data-formatter/typedef_array/Makefile

commit 56782703f6ee83460b502dac7a7eee3bd860d8cb
Author: Sean Callanan <scallanan@apple.com>
Date:   Mon Apr 20 16:31:29 2015 +0000

    This patch implements several improvements to the
    module-loading support for the expression parser.
    
    - It adds support for auto-loading modules referred
      to by a compile unit.  These references are
      currently in the form of empty translation units.
      This functionality is gated by the setting
    
      target.auto-import-clang-modules (boolean) = false
    
    - It improves and corrects support for loading
      macros from modules, currently by textually
      pasting all #defines into the user's expression.
      The improvements center around including only those
      modules that are relevant to the current context -
      hand-loaded modules and the modules that are imported
      from the current compile unit.
    
    - It adds an "opt-in" mechanism for all of this
      functionality.  Modules have to be explicitly
      imported (via @import) or auto-loaded (by enabling
      the above setting) to enable any of this
      functionality.
    
    It also adds support to the compile unit and symbol
    file code to deal with empty translation units that
    indicate module imports, and plumbs this through to
    the CompileUnit interface.
    
    Finally, it makes the following changes to the test
    suite:
    
    - It adds a testcase that verifies that modules are
      automatically loaded when the appropriate setting
      is enabled (lang/objc/modules-auto-import); and
    
    - It modifies lanb/objc/modules-incomplete to test
      the case where a module #undefs something that is
      #defined in another module.
    
    <rdar://problem/20299554>
    
    
    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@235313 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/functionalities/data-formatter/typedef_array/Makefile b/test/functionalities/data-formatter/typedef_array/Makefile
index 3e2b018..e69de29 100644
--- a/test/functionalities/data-formatter/typedef_array/Makefile
+++ b/test/functionalities/data-formatter/typedef_array/Makefile
@@ -1,4 +0,0 @@
-LEVEL = ../../../make
-CXX_SOURCES := main.cpp
-CXXFLAGS += -std=c++11
-include $(LEVEL)/Makefile.rules

commit add55ff2159df787329c10938dc34902ec73c793
Author: Tamas Berghammer <tberghammer@google.com>
Date:   Wed Apr 1 10:48:10 2015 +0000

    Add missing makefile got test case
    
    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@233797 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/functionalities/data-formatter/typedef_array/Makefile b/test/functionalities/data-formatter/typedef_array/Makefile
new file mode 100644
index 0000000..3e2b018
--- /dev/null
+++ b/test/functionalities/data-formatter/typedef_array/Makefile
@@ -0,0 +1,4 @@
+LEVEL = ../../../make
+CXX_SOURCES := main.cpp
+CXXFLAGS += -std=c++11
+include $(LEVEL)/Makefile.rules

commit ec0026cc877932ae3c7ebb78176652a1bd4590a0
Author: Zachary Turner <zturner@google.com>
Date:   Tue Feb 17 17:55:50 2015 +0000

    Revert "Revert "I had recently added a new SBFrame::GetVariables() overload with yet another bool argument""
    
    Reverting this commit led to other failures which I did not see at
    first.  This turned out to be an easy problem to fix, so I added
    SBVariablesOptions.cpp to the CMakeLists.txt.  In the future please
    try to make sure new files are added to CMake.
    
    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@229516 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/functionalities/data-formatter/typedef_array/Makefile b/test/functionalities/data-formatter/typedef_array/Makefile
deleted file mode 100644
index 3e2b018..0000000
--- a/test/functionalities/data-formatter/typedef_array/Makefile
+++ /dev/null
@@ -1,4 +0,0 @@
-LEVEL = ../../../make
-CXX_SOURCES := main.cpp
-CXXFLAGS += -std=c++11
-include $(LEVEL)/Makefile.rules

commit d63362ee08e1d385075fc277974a0d08cb3a5c96
Author: Zachary Turner <zturner@google.com>
Date:   Tue Feb 17 17:42:05 2015 +0000

    Revert "I had recently added a new SBFrame::GetVariables() overload with yet another bool argument"
    
    This reverts commit r228975.  It was causing link errors
    on the Windows bots, since last Thursday.
    
    http://lab.llvm.org:8011/builders/lldb-x86-win7-msvc/builds/725
    
    Conflicts:
    	lldb.xcodeproj/project.pbxproj
    
    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@229514 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/functionalities/data-formatter/typedef_array/Makefile b/test/functionalities/data-formatter/typedef_array/Makefile
new file mode 100644
index 0000000..3e2b018
--- /dev/null
+++ b/test/functionalities/data-formatter/typedef_array/Makefile
@@ -0,0 +1,4 @@
+LEVEL = ../../../make
+CXX_SOURCES := main.cpp
+CXXFLAGS += -std=c++11
+include $(LEVEL)/Makefile.rules

commit 467d399de7d315050ced306d3efc83d9bab10b9b
Author: Enrico Granata <egranata@apple.com>
Date:   Thu Feb 12 23:09:17 2015 +0000

    I had recently added a new SBFrame::GetVariables() overload with yet another bool argument
    
    We talked about it internally - and came to the conclusion that it's time to have an options class
    
    This commit adds an SBVariablesOptions class and goes through all the required dance
    
    
    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@228975 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/functionalities/data-formatter/typedef_array/Makefile b/test/functionalities/data-formatter/typedef_array/Makefile
deleted file mode 100644
index 3e2b018..0000000
--- a/test/functionalities/data-formatter/typedef_array/Makefile
+++ /dev/null
@@ -1,4 +0,0 @@
-LEVEL = ../../../make
-CXX_SOURCES := main.cpp
-CXXFLAGS += -std=c++11
-include $(LEVEL)/Makefile.rules

commit 91a491e63ea900c9232d87d2602ae01421fda3ba
Author: Pavel Labath <labath@google.com>
Date:   Thu Feb 12 14:43:35 2015 +0000

    Re-add makefiles of inline tests
    
    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@228925 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/functionalities/data-formatter/typedef_array/Makefile b/test/functionalities/data-formatter/typedef_array/Makefile
new file mode 100644
index 0000000..3e2b018
--- /dev/null
+++ b/test/functionalities/data-formatter/typedef_array/Makefile
@@ -0,0 +1,4 @@
+LEVEL = ../../../make
+CXX_SOURCES := main.cpp
+CXXFLAGS += -std=c++11
+include $(LEVEL)/Makefile.rules

commit 9cb9b53da2f86d339724044e7c741ada08e0b40d
Author: Enrico Granata <egranata@apple.com>
Date:   Tue Feb 10 00:30:07 2015 +0000

    Add a JSON producer to LLDB - this is a set of classes that encapsulate JSON objects and allow you to write them to a Stream for subsequent processing
    
    Using this JSON producer, write a little tool that expands its own command-line arguments and dumps them to stdout as a JSON array
    
    
    
    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@228636 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/functionalities/data-formatter/typedef_array/Makefile b/test/functionalities/data-formatter/typedef_array/Makefile
deleted file mode 100644
index 3e2b018..0000000
--- a/test/functionalities/data-formatter/typedef_array/Makefile
+++ /dev/null
@@ -1,4 +0,0 @@
-LEVEL = ../../../make
-CXX_SOURCES := main.cpp
-CXXFLAGS += -std=c++11
-include $(LEVEL)/Makefile.rules

commit 9bfc4c5b459b9d1f182dd323e461dcddfae89f2c
Author: Pavel Labath <labath@google.com>
Date:   Thu Feb 5 17:03:22 2015 +0000

    Check-in generated test makefiles
    
    for rationale, see D7407.
    
    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@228314 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/functionalities/data-formatter/typedef_array/Makefile b/test/functionalities/data-formatter/typedef_array/Makefile
new file mode 100644
index 0000000..3e2b018
--- /dev/null
+++ b/test/functionalities/data-formatter/typedef_array/Makefile
@@ -0,0 +1,4 @@
+LEVEL = ../../../make
+CXX_SOURCES := main.cpp
+CXXFLAGS += -std=c++11
+include $(LEVEL)/Makefile.rules

Revision Contents

PathSize
lldb/
trunk/
test/
functionalities/
data-formatter/
typedef_array/
4 lines

Diff 24057

lldb/trunk/test/functionalities/data-formatter/typedef_array/Makefile

LEVEL = ../../../make
CXX_SOURCES := main.cpp
CXXFLAGS += -std=c++11
include $(LEVEL)/Makefile.rules