Stop read thread of Communication on EOF

[tberghammer]

Summary

Stop read thread of Communication on EOF

Previously the read thread was only stopped if CloseOnEOF was set on the
communication channel. It caused it to spin in case of an EOF because
::select() always reported that we can read from the file descriptor.
This CL change this behavior with stopping the read thread on EOF but do
a disconnect only if CloseOnEOF is enabled.

[labath]

lgtm, but please wait for a signoff from greg

[clayborg]

Looks good.

lldb/trunk/source/Core/Communication.cpp

if (m_read_thread_enabled)
             const uint32_t event_type = event_sp->GetType();
             if (event_type & eBroadcastBitReadThreadGotBytes)
             {
                 return GetCachedBytes (dst, dst_len);
             }
 
             if (event_type & eBroadcastBitReadThreadDidExit)
             {
+                if (GetCloseOnEOF ())
                     Disconnect (NULL);
                 break;
             }
         }
         return 0;
     }
 
     // We aren't using a read thread, just read the data synchronously in this
     // thread.
while (!done && comm->m_read_thread_enabled)
         }
 
         switch (status)
         {
         case eConnectionStatusSuccess:
             break;
 
         case eConnectionStatusEndOfFile:
-            if (comm->GetCloseOnEOF())
-                 done = true;
-             break;
         case eConnectionStatusError:            // Check GetError() for details
             if (error.GetType() == eErrorTypePOSIX && error.GetError() == EIO)
             {
                 // EIO on a pipe is usually caused by remote shutdown
                 comm->Disconnect ();
                 done = true;
             }
             if (log)