Simplifying memory globalization from the front end to move optimizations to the middle end.
Needs ReviewPublic
Actions

Authored by josemonsalve2 on Nov 2 2020, 10:42 PM.

Details

Reviewers

Summary

Memory globalization was fully implemented in the front end. There are three runtime
functions in Libomptarget:

__kmpc_data_sharing_push_stack
__kmpc_data_sharing_coalesced_push_stack
__kmpc_data_sharing_pop_stack

The front end performed a scape analysis and created a record declare with all the stack
variables. Then, based on the context (isTTD and other parameters) it would create a push
for the size of the record, or for that size multiplied by the WARP (to globalize for the
whole WARP.

This PR removes the record creation, and it simplifies the front end to be a simple runtime
call that will be later on optimized in the middle end. The middle end will be able to
determine the stack variables that do scape, and those that do not, as well as the
approrpiate merging of different globalized variables

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	100 ms	x64 debian > Clang.OpenMP::nvptx_parallel_for_codegen.cpp Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/12.0.0/include -nostdsysteminc -verify -fopenmp -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm-bc /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/nvptx_parallel_for_codegen.cpp -o /mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/OpenMP/Output/nvptx_parallel_for_codegen.cpp.tmp-ppc-host.bc
	150 ms	x64 debian > Clang.OpenMP::nvptx_target_codegen.cpp Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/12.0.0/include -nostdsysteminc -verify -fopenmp -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm-bc /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/nvptx_target_codegen.cpp -o /mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/OpenMP/Output/nvptx_target_codegen.cpp.tmp-ppc-host.bc
	100 ms	x64 debian > Clang.OpenMP::nvptx_target_teams_distribute_codegen.cpp Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/12.0.0/include -nostdsysteminc -verify -fopenmp -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm-bc /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/nvptx_target_teams_distribute_codegen.cpp -o /mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/OpenMP/Output/nvptx_target_teams_distribute_codegen.cpp.tmp-ppc-host.bc
	220 ms	x64 debian > Clang.OpenMP::nvptx_target_teams_distribute_parallel_for_codegen.cpp Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/12.0.0/include -nostdsysteminc -verify -fopenmp -fopenmp-version=45 -fopenmp-cuda-mode -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm-bc /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_codegen.cpp -o /mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/OpenMP/Output/nvptx_target_teams_distribute_parallel_for_codegen.cpp.tmp-ppc-host.bc
	160 ms	x64 debian > Clang.OpenMP::nvptx_target_teams_distribute_parallel_for_simd_codegen.cpp Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/12.0.0/include -nostdsysteminc -verify -fopenmp -fopenmp-version=45 -fopenmp-cuda-mode -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm-bc /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_simd_codegen.cpp -o /mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/OpenMP/Output/nvptx_target_teams_distribute_parallel_for_simd_codegen.cpp.tmp-ppc-host.bc
		View Full Test Results (17 Failed)