This is an archive of the discontinued LLVM Phabricator instance.

Add COMPILER_RT_ABI attribute to declarations of builtin functions in unittests
ClosedPublic

Authored by dschuff on Apr 16 2015, 3:38 PM.

Details

Summary

This makes their local declarations match their definitions for ARM targets,
where they have a different calling convention.

This really only affects functions that use floating point types (since the
runtime functions use soft-float, and some targets may default to hard-float)
but it seemed good to make it uniform and do the int-only ones too.

Diff Detail

Repository
rL LLVM

Event Timeline

dschuff updated this revision to Diff 23884.Apr 16 2015, 3:38 PM
dschuff retitled this revision from to Add COMPILER_RT_ABI attribute to declarations of builtin functions in unittests.
dschuff updated this object.
dschuff edited the test plan for this revision. (Show Details)
dschuff added a subscriber: Unknown Object (MLST).

I can't see why this would be a bad idea, given that it makes it homogeneous and in sync with the lib/builtins/ function declarations.

rengolin accepted this revision.Apr 24 2015, 6:14 AM
rengolin added a reviewer: rengolin.

Hi Derek,

I say go for it, and we'll see if there's any side effects on the buildbots.

LGTM, Thanks!

This revision is now accepted and ready to land.Apr 24 2015, 6:14 AM

thanks, will do.

This revision was automatically updated to reflect the committed changes.