Page MenuHomePhabricator

[NFC intended] Refactor SinkAndHoistLICMFlags to allow others to construct without exposing internals
ClosedPublic

Authored by jamieschmeiser on Oct 30 2020, 10:38 AM.

Details

Summary

[No intended Functional Change] Refactor SinkAdHoistLICMFlags from a
struct to a class with accessors and constructors to allow other
classes to construct flags with meaningful defaults while not
exposing LICM internal details.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2020, 10:38 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
jamieschmeiser retitled this revision from [NFC intended] Refactor SinkAdHoistLICMFlags to allow others to construct without exposing internals to [NFC intended] Refactor SinkAndHoistLICMFlags to allow others to construct without exposing internals.Oct 30 2020, 10:51 AM
asbirlea accepted this revision.Oct 30 2020, 2:59 PM

Thank you!

This revision is now accepted and ready to land.Oct 30 2020, 2:59 PM

No changes, just rebasing to new master to get retesting to ensure clean test run