This is an archive of the discontinued LLVM Phabricator instance.

[mips] Implement add.ps, mul.ps and sub.ps
ClosedPublic

Authored by michael-roe on Oct 28 2020, 10:58 AM.

Diff Detail

Event Timeline

michael-roe created this revision.Oct 28 2020, 10:58 AM
michael-roe requested review of this revision.Oct 28 2020, 10:58 AM
atanasyan accepted this revision.Oct 28 2020, 3:21 PM

LGTM with a few nits. Thanks.

Do you have commit access?

llvm/test/MC/Mips/mips2/invalid-mips5.s
8

Fix indentation.

llvm/test/MC/Mips/mips3/invalid-mips5.s
8

Ditto

llvm/test/MC/Mips/mips4/invalid-mips5.s
8

Ditto

llvm/test/MC/Mips/mips64r2/valid.s
271

Ditto

llvm/test/MC/Mips/mips64r6/invalid-mips5.s
8

Ditto

This revision is now accepted and ready to land.Oct 28 2020, 3:21 PM

LGTM with a few nits. Thanks.

Do you have commit access?

No, I don't have commit access. Please could you commit it for me?

Thanks,
Mike

This revision was landed with ongoing or failed builds.Oct 30 2020, 12:59 AM
This revision was automatically updated to reflect the committed changes.