This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Convert PrintModuleMap to DumpProcessMap
ClosedPublic

Authored by tejohnson on Oct 17 2020, 10:52 AM.

Details

Summary

As discussed in the review for D87120 (specifically at
https://reviews.llvm.org/D87120#inline-831939), clean up PrintModuleMap
and DumpProcessMap usage differences. The former is only implemented for
Mac OSX, whereas the latter is implemented for all OSes. The former is
called by asan and tsan, and the latter by hwasan and now memprof, under
the same option. Simply rename the PrintModuleMap implementation for Mac
to DumpProcessMap, remove other empty PrintModuleMap implementations,
and convert asan/tsan to new name. The existing posix DumpProcessMap is
disabled for SANITIZER_MAC.

Diff Detail

Event Timeline

tejohnson created this revision.Oct 17 2020, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2020, 10:52 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
tejohnson requested review of this revision.Oct 17 2020, 10:52 AM
vitalybuka accepted this revision.Oct 20 2020, 1:45 AM
This revision is now accepted and ready to land.Oct 20 2020, 1:45 AM
This revision was landed with ongoing or failed builds.Oct 21 2020, 12:47 PM
This revision was automatically updated to reflect the committed changes.