Page MenuHomePhabricator

[amdgpu] Enable use of AA during codegen.
AcceptedPublic

Authored by hliao on Tue, Oct 13, 8:24 AM.

Details

Reviewers
rampitec
arsenm

Diff Detail

Unit TestsFailed

TimeTest
420 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

hliao created this revision.Tue, Oct 13, 8:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Oct 13, 8:24 AM
hliao requested review of this revision.Tue, Oct 13, 8:24 AM
hliao added a comment.Tue, Oct 13, 8:27 AM

Register pressure tests have to disable AMDGPU AA to pass the test; otherwise, the register pressure is reduced after using AA.

rampitec accepted this revision.Tue, Oct 13, 12:07 PM

LGTM, but please run PSDB first.

This revision is now accepted and ready to land.Tue, Oct 13, 12:07 PM
hliao updated this revision to Diff 299778.Wed, Oct 21, 12:23 PM

Add an option to turn on/off the use of AA during codegen.