Page MenuHomePhabricator

[MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled
ClosedPublic

Authored by mati865 on Oct 12 2020, 2:57 AM.

Details

Summary

Otherwise it's easy to hit 2^16 DLL exports limit.

Diff Detail

Event Timeline

mati865 created this revision.Oct 12 2020, 2:57 AM

+1, looks sensible to me - I can give it the formal approval a bit later, but leaving it open for a bit for others to comment on first.

ASDenysPetrov accepted this revision.Oct 12 2020, 4:33 AM

It works for me. Well done!

I've applied your patch and tried this:

cmake -GNinja ../llvm -DLLVM_LIT_ARGS=-sv -DLLVM_LINK_LLVM_DYLIB=ON -DLLVM_ENABLE_PROJECTS=clang -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../../install -DLLVM_ENABLE_ASSERTIONS=ON
ninja
This revision is now accepted and ready to land.Oct 12 2020, 4:33 AM
This revision was landed with ongoing or failed builds.Oct 12 2020, 1:28 PM
This revision was automatically updated to reflect the committed changes.