This is an archive of the discontinued LLVM Phabricator instance.

Differential D8886

Allow undefined symbols in shared library by default
ClosedPublic

Authored by davide on Apr 7 2015, 5:23 PM.

Details

Reviewers
• rafael
• shankar.easwaran
Commits
rG0e6a26467324: Allow undefined symbols in shared library by default.
rLLD234378: Allow undefined symbols in shared library by default.
rL234378: Allow undefined symbols in shared library by default.
Summary

As previously discussed on IRC.
Fixes https://llvm.org/bugs/show_bug.cgi?id=23035

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 23385.Apr 7 2015, 5:23 PM
davide retitled this revision from to Allow undefined symbols in shared library by default.
davide updated this object.
davide edited the test plan for this revision. (Show Details)
davide added a reviewer: • rafael.
davide set the repository for this revision to rL LLVM.
davide added a project: lld.
davide added a subscriber: Unknown Object (MLST).
davide added a subscriber: davide.Apr 7 2015, 5:43 PM
• shankar.easwaran accepted this revision.Apr 7 2015, 5:51 PM
• shankar.easwaran added a reviewer: • shankar.easwaran.
• shankar.easwaran added a subscriber: • shankar.easwaran.

Lgtm

This revision is now accepted and ready to land.Apr 7 2015, 5:51 PM
emaste added a subscriber: emaste.Apr 7 2015, 5:52 PM
Closed by commit rL234378: Allow undefined symbols in shared library by default. (authored by davide). · Explain WhyApr 7 2015, 6:03 PM
This revision was automatically updated to reflect the committed changes.
emaste mentioned this in D8901: Allow undefined symbols in shared library by default.Apr 8 2015, 11:43 AM

Revision Contents

PathSize
lld/
trunk/
lib/
Core/
2 lines

Diff 23387

lld/trunk/lib/Core/LinkingContext.cpp

Show All 18 Lines
LinkingContext::LinkingContext() LinkingContext::LinkingContext()
: _deadStrip(false), _allowDuplicates(false), : _deadStrip(false), _allowDuplicates(false),
_globalsAreDeadStripRoots(false), _globalsAreDeadStripRoots(false),
_searchArchivesToOverrideTentativeDefinitions(false), _searchArchivesToOverrideTentativeDefinitions(false),
_searchSharedLibrariesToOverrideTentativeDefinitions(false), _searchSharedLibrariesToOverrideTentativeDefinitions(false),
_warnIfCoalesableAtomsHaveDifferentCanBeNull(false), _warnIfCoalesableAtomsHaveDifferentCanBeNull(false),
_warnIfCoalesableAtomsHaveDifferentLoadName(false), _warnIfCoalesableAtomsHaveDifferentLoadName(false),
_printRemainingUndefines(true), _allowRemainingUndefines(false), _printRemainingUndefines(true), _allowRemainingUndefines(false),
_logInputFiles(false), _allowShlibUndefines(false), _logInputFiles(false), _allowShlibUndefines(true),
_outputFileType(OutputFileType::Default), _nextOrdinal(0) {} _outputFileType(OutputFileType::Default), _nextOrdinal(0) {}
LinkingContext::~LinkingContext() {} LinkingContext::~LinkingContext() {}
bool LinkingContext::validate(raw_ostream &diagnostics) { bool LinkingContext::validate(raw_ostream &diagnostics) {
return validateImpl(diagnostics); return validateImpl(diagnostics);
} }
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines