Page MenuHomePhabricator

[CMake] Don't use CMakePushCheckState
ClosedPublic

Authored by phosek on Oct 2 2020, 2:19 PM.

Details

Summary

When we call cmake_pop_check_state, we undo any changes to REQUIRED
variables performed by HandleLLVMOptions which is undesirable. Rather
use replacement which is what we've used prior to 8d26760a.

Diff Detail

Event Timeline

phosek created this revision.Oct 2 2020, 2:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2020, 2:19 PM
phosek requested review of this revision.Oct 2 2020, 2:19 PM
phosek edited the summary of this revision. (Show Details)
smeenai accepted this revision.Oct 2 2020, 2:37 PM

LGTM

This revision is now accepted and ready to land.Oct 2 2020, 2:37 PM
bjope added a subscriber: bjope.Oct 2 2020, 3:16 PM
This revision was landed with ongoing or failed builds.Oct 2 2020, 5:14 PM
This revision was automatically updated to reflect the committed changes.