This is an archive of the discontinued LLVM Phabricator instance.

Add tests for non-virtual call checking.
ClosedPublic

Authored by pcc on Apr 1 2015, 5:10 PM.

Diff Detail

Event Timeline

pcc updated this revision to Diff 23105.Apr 1 2015, 5:10 PM
pcc retitled this revision from to Add tests for non-virtual call checking..
pcc updated this object.
pcc edited the test plan for this revision. (Show Details)
pcc added reviewers: kcc, jfb.
pcc added a subscriber: Unknown Object (MLST).
jfb edited edge metadata.Apr 1 2015, 5:27 PM

lgtm besides comment.

test/cfi/nvcall.cpp
51

Could you add a comment which explain the point of B32/B64/BM? IIUC it's just creating bigger numbers of derived classes, all with a bunch of virtuals?

pcc added inline comments.Apr 1 2015, 5:36 PM
test/cfi/nvcall.cpp
51

Most of the tests in this directory use these macros, so I've documented them in a README.txt file in this directory.

This revision was automatically updated to reflect the committed changes.