Page MenuHomePhabricator

[NewPM] Port -print-alias-sets to NPM
ClosedPublic

Authored by aeubanks on Tue, Sep 15, 11:49 AM.

Details

Summary

Really it should be named print<alias-sets>, but for the sake of
changing fewer tests, added a TODO to rename after NPM switch and test
cleanup.

Diff Detail

Event Timeline

aeubanks created this revision.Tue, Sep 15, 11:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Sep 15, 11:49 AM
aeubanks requested review of this revision.Tue, Sep 15, 11:49 AM
ychen added inline comments.Tue, Sep 15, 5:15 PM
llvm/lib/Analysis/AliasSetTracker.cpp
752

No strong feeling but I'm not really sure how big AliasSetTracker it could go or if it owns a lot of memory. This does not look like a critical path to make putting it on stack worthwhile. Play safe and keep it on the heap?

aeubanks added inline comments.Tue, Sep 15, 5:52 PM
llvm/lib/Analysis/AliasSetTracker.cpp
752

AliasSetTracker doesn't look special, it seems like a normal class with normal member variables with normal sizes.
This was mostly due to me really not liking raw news/deletes.

ychen accepted this revision.Wed, Sep 16, 5:00 PM
This revision is now accepted and ready to land.Wed, Sep 16, 5:00 PM
This revision was automatically updated to reflect the committed changes.