This is an archive of the discontinued LLVM Phabricator instance.

Differential D8761

Remove dead code
ClosedPublic

Authored by davide on Mar 31 2015, 11:20 PM.

Details

Reviewers
zturner
clayborg
Commits
rG029838496f43: Remove dead code in ProcessPOSIX.
rLLDB233831: Remove dead code in ProcessPOSIX.
rL233831: Remove dead code in ProcessPOSIX.
Summary

This code is dead right now. If nobody else is planning to use it, I'd like to remove it. It can be reintroduced if people needs it again.

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 23030.Mar 31 2015, 11:20 PM
davide retitled this revision from to Remove dead code.
davide updated this object.
davide edited the test plan for this revision. (Show Details)
davide added reviewers: clayborg, zturner.
davide set the repository for this revision to rL LLVM.
davide added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Apr 1 2015, 9:28 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2015, 9:28 AM
Closed by commit rL233831: Remove dead code in ProcessPOSIX. (authored by davide). · Explain WhyApr 1 2015, 11:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
source/
Plugins/
Process/
POSIX/
33 lines

Diff 23083

lldb/trunk/source/Plugins/Process/POSIX/ProcessPOSIX.cpp

Show All 30 Lines
#include "Plugins/Process/Utility/InferiorCallPOSIX.h" #include "Plugins/Process/Utility/InferiorCallPOSIX.h"
#include "Plugins/Process/Linux/ProcessMonitor.h" #include "Plugins/Process/Linux/ProcessMonitor.h"
#include "POSIXThread.h" #include "POSIXThread.h"
using namespace lldb; using namespace lldb;
using namespace lldb_private; using namespace lldb_private;
//------------------------------------------------------------------------------ //------------------------------------------------------------------------------
// Static functions.
#if 0
Process*
ProcessPOSIX::CreateInstance(Target& target, Listener &listener)
{
return new ProcessPOSIX(target, listener);
}
void
ProcessPOSIX::Initialize()
{
static bool g_initialized = false;
if (!g_initialized)
{
g_initialized = true;
PluginManager::RegisterPlugin(GetPluginNameStatic(),
GetPluginDescriptionStatic(),
CreateInstance);
Log::Callbacks log_callbacks = {
ProcessPOSIXLog::DisableLog,
ProcessPOSIXLog::EnableLog,
ProcessPOSIXLog::ListLogCategories
};
Log::RegisterLogChannel (ProcessPOSIX::GetPluginNameStatic(), log_callbacks);
}
}
#endif
//------------------------------------------------------------------------------
// Constructors and destructors. // Constructors and destructors.
ProcessPOSIX::ProcessPOSIX(Target& target, Listener &listener, UnixSignalsSP &unix_signals_sp) ProcessPOSIX::ProcessPOSIX(Target& target, Listener &listener, UnixSignalsSP &unix_signals_sp)
: Process(target, listener, unix_signals_sp), : Process(target, listener, unix_signals_sp),
m_byte_order(lldb::endian::InlHostByteOrder()), m_byte_order(lldb::endian::InlHostByteOrder()),
m_monitor(NULL), m_monitor(NULL),
m_module(NULL), m_module(NULL),
m_message_mutex (Mutex::eMutexTypeRecursive), m_message_mutex (Mutex::eMutexTypeRecursive),
▲ Show 20 Lines • Show All 885 Lines • Show Last 20 Lines