Page MenuHomePhabricator

[llvm-install-name-tool] Add -V flag
ClosedPublic

Authored by alexshap on Mon, Sep 7, 9:15 PM.

Details

Summary

This diff adds -V alias for --version to make llvm-install-name-tool consistent with other tools (llvm-objcopy, llvm-strip, etc).

Test plan: make check-all

Diff Detail

Event Timeline

alexshap created this revision.Mon, Sep 7, 9:15 PM
Herald added a project: Restricted Project. · View Herald Transcript
alexshap requested review of this revision.Mon, Sep 7, 9:15 PM
MaskRay accepted this revision.Mon, Sep 7, 9:37 PM

LGTM.

llvm/tools/llvm-objcopy/InstallNameToolOpts.td
36

(Alias may not need a line wrap)

This revision is now accepted and ready to land.Mon, Sep 7, 9:37 PM
jhenderson accepted this revision.Tue, Sep 8, 12:31 AM

LGTM too. I noticed that --version (and -V) are missing from the Command Guide for llvm-install-name-tool, along with --help, unlike e.g. llvm-objcopy. Perhaps worth a separate patch if you get a few minutes to fix the doc.

This revision was automatically updated to reflect the committed changes.