This is an archive of the discontinued LLVM Phabricator instance.

Thread safety analysis: Test and document release_generic_capability
ClosedPublic

Authored by aaronpuchert on Sep 2 2020, 5:52 PM.

Details

Summary

The old locking attributes had a generic release, but as it turns out
the capability-based attributes have it as well.

Diff Detail

Event Timeline

aaronpuchert created this revision.Sep 2 2020, 5:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2020, 5:52 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaronpuchert requested review of this revision.Sep 2 2020, 5:52 PM
This revision is now accepted and ready to land.Sep 3 2020, 6:48 AM

Add some prose, not just code. Otherwise our list of attributes would be incomplete.

@aaron.ballman, I think you should have another look. Sorry for missing that in my first patch.

aaron.ballman accepted this revision.Sep 5 2020, 7:11 AM

LGTM!

clang/docs/ThreadSafetyAnalysis.rst
804

This is not something you should feel obligated to fix (esp not as part of this patch), but I just realized we have a naming-related UB here in C++ with the trailing double underscores: http://eel.is/c++draft/lex.name#3.1 We should probably pick a different identifier to use.