This is an archive of the discontinued LLVM Phabricator instance.

Differential D86846

[NFC] Adding pythonenv* to .gitignore
ClosedPublic

Authored by plotfi on Aug 29 2020, 8:27 PM.

Details

Reviewers
echristo
Commits
rG0ac81333ebc3: [NFC] Adding pythonenv* to .gitignore
Summary

Github Codespaces generates a pythonenv3.8 directory inside of the llvm-project checkout. This is a diff to .gitconfig so that this directory is ignored.

Github Codespaces is a new Github feature that lets you go to the llvm-project github, click a button and get an editor and a whole checkout of the project.
It creates a pythonenv3.8 directory in the projects checkout, and I think it would be nice if it were ignored unless theres a good reason it shouldn't be?

Diff Detail

Event Timeline

plotfi created this revision.Aug 29 2020, 8:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2020, 8:27 PM
Herald added subscribers: llvm-commits, danielkiss. · View Herald Transcript
plotfi requested review of this revision.Aug 29 2020, 8:27 PM
plotfi edited the summary of this revision. (Show Details)Aug 29 2020, 8:34 PM
Harbormaster completed remote builds in B70031: Diff 288828.Aug 29 2020, 9:34 PM
echristo accepted this revision.Aug 29 2020, 9:37 PM
This revision is now accepted and ready to land.Aug 29 2020, 9:37 PM
lebedev.ri retitled this revision from [NFC] Adding pythonenv* to .gitconfig. to [NFC] Adding pythonenv* to .gitignore.Aug 29 2020, 11:20 PM
This revision was landed with ongoing or failed builds.Sep 3 2020, 7:45 PM
Closed by commit rG0ac81333ebc3: [NFC] Adding pythonenv* to .gitignore (authored by plotfi, committed by Puyan Lotfi <plotfi@fb.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Puyan Lotfi <plotfi@fb.com> added a commit: rG0ac81333ebc3: [NFC] Adding pythonenv* to .gitignore.

Revision Contents

PathSize
2 lines

Diff 289843

.gitignore

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
/.idea /.idea
#==============================================================================# #==============================================================================#
# Directories to ignore (do not add trailing '/'s, they skip symlinks). # Directories to ignore (do not add trailing '/'s, they skip symlinks).
#==============================================================================# #==============================================================================#
# VS2017 and VSCode config files. # VS2017 and VSCode config files.
.vscode .vscode
.vs .vs
# pythonenv for github Codespaces
pythonenv*
# clangd index. (".clangd" is a config file now, thus trailing slash) # clangd index. (".clangd" is a config file now, thus trailing slash)
.clangd/ .clangd/
.cache .cache
# static analyzer regression testing project files # static analyzer regression testing project files
/clang/utils/analyzer/projects/*/CachedSource /clang/utils/analyzer/projects/*/CachedSource
/clang/utils/analyzer/projects/*/PatchedSource /clang/utils/analyzer/projects/*/PatchedSource
/clang/utils/analyzer/projects/*/ScanBuildResults /clang/utils/analyzer/projects/*/ScanBuildResults
/clang/utils/analyzer/projects/*/RefScanBuildResults /clang/utils/analyzer/projects/*/RefScanBuildResults