Page MenuHomePhabricator

[SyntaxTree] Ignore leaf implicit `CXXConstructExpr`
ClosedPublic

Authored by eduucaldas on Thu, Aug 27, 4:44 AM.

Diff Detail

Event Timeline

eduucaldas created this revision.Thu, Aug 27, 4:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Aug 27, 4:44 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Thu, Aug 27, 4:44 AM
eduucaldas edited the summary of this revision. (Show Details)Mon, Aug 31, 10:38 AM
eduucaldas added a reviewer: gribozavr2.
gribozavr2 accepted this revision.Mon, Aug 31, 12:24 PM
gribozavr2 added inline comments.
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
552

Do we have tests for calling constructors with arguments?

n::S s3(1, 2, 3);
n::S s3{1, 2, 3};

If not, please add them.

This revision is now accepted and ready to land.Mon, Aug 31, 12:24 PM
eduucaldas updated this revision to Diff 290224.EditedMon, Sep 7, 2:37 AM
eduucaldas marked an inline comment as done.

.

eduucaldas added inline comments.Mon, Sep 7, 2:44 AM
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
552

We have. I improved their coverage in the parent patch

eduucaldas updated this revision to Diff 290260.Mon, Sep 7, 5:40 AM

Add comments

gribozavr2 accepted this revision.Mon, Sep 7, 9:11 AM
gribozavr2 added inline comments.
clang/lib/Tooling/Syntax/BuildTree.cpp
1136
1137

I don't quite understand which test is checking the CXXDefaultArgExpr case -- could you help me?

eduucaldas marked 2 inline comments as done.

answer comments

clang/lib/Tooling/Syntax/BuildTree.cpp
1137

CXXDefaultArgExpr is in another patch. Although I discovered while working on this it is as linked to Constructors as it is linked to function calls. As such I decided to add that in a separate patch

gribozavr2 added inline comments.Mon, Sep 7, 11:54 AM
clang/lib/Tooling/Syntax/BuildTree.cpp
1137

OK, added a comment in that review.

This revision was automatically updated to reflect the committed changes.