This is an archive of the discontinued LLVM Phabricator instance.

Replace sys.platform skips in tests with @skip decorators which check against remote platform.
ClosedPublic

Authored by flackr on Mar 27 2015, 10:06 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

flackr updated this revision to Diff 22803.Mar 27 2015, 10:06 AM
flackr retitled this revision from to Replace sys.platform skips in tests with @skip decorators which check against remote platform..
flackr updated this object.
flackr edited the test plan for this revision. (Show Details)
flackr added reviewers: clayborg, tberghammer.
flackr set the repository for this revision to rL LLVM.
flackr added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Mar 27 2015, 10:19 AM
clayborg edited edge metadata.

lgtm

This revision is now accepted and ready to land.Mar 27 2015, 10:19 AM
tberghammer accepted this revision.Mar 30 2015, 3:55 AM
tberghammer edited edge metadata.

lgtm

This revision was automatically updated to reflect the committed changes.
emaste added a subscriber: emaste.Mar 31 2015, 9:27 AM

This causes massive test run failures on FreeBSD because the triple OS component is 'freebsd10.1'

This causes massive test run failures on FreeBSD because the triple OS component is 'freebsd10.1'

I can update this to continue to do a prefix string check to ignore version number. Why do we have a version number in the OS component on freebsd but not the other platforms as far as I can tell?

This causes massive test run failures on FreeBSD because the triple OS component is 'freebsd10.1'

Fixed in rL233705

dawn added a subscriber: dawn.Apr 7 2015, 2:53 PM
dawn added a comment.Apr 7 2015, 3:07 PM

This change (committed in rev.233547) caused many tests to no longer run on our OSX Jenkins build. Since we check that a minimum number of tests run, our build is now failing. We run the tests using:

./dosep.py --options "-v --executable $INSTALLDIR/bin/lldb" 2>&1 | tee $INSTALLDIR/test_out.log || true

Tests which used to run (like test_NSString_expr_commands_with_dwarf (TestObjCMethods2.FoundationTestCase2) and 11 other tests in that same file) aren't reported as skipped - they are simply absent from the log.
Please rework this patch? Thank you.