Page MenuHomePhabricator

Fix failing tests after VCTOOLSDIR change
ClosedPublic

Authored by zahen on Wed, Aug 26, 7:28 AM.

Details

Summary

Switch from hardcoded x64 arch to a regex in the target triple

Diff Detail

Event Timeline

zahen created this revision.Wed, Aug 26, 7:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 26, 7:28 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
zahen requested review of this revision.Wed, Aug 26, 7:28 AM
hans accepted this revision.Wed, Aug 26, 7:29 AM
This revision is now accepted and ready to land.Wed, Aug 26, 7:29 AM
zahen added a comment.Wed, Aug 26, 7:33 AM

Sorry again about the break! As with the initial patch, I'll need you to land this change.

This revision was landed with ongoing or failed builds.Wed, Aug 26, 7:34 AM
Closed by commit rG7a34dca0f391: Fix failing tests after VCTOOLSDIR change (authored by zahen, committed by hans). · Explain Why
This revision was automatically updated to reflect the committed changes.
hans added a comment.Wed, Aug 26, 7:35 AM

Sorry again about the break! As with the initial patch, I'll need you to land this change.

No worries, sorry for not catching it in the review. Pushed now as 7a34dca0f3918ab1c0397e56dd64a3c04164c8b6.