Details
- Reviewers
smeenai - Group Reviewers
Restricted Project - Commits
- rG3da2130e45a4: [lld-macho] Emit the right header flags for weak bindings/symbols
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Time | Test | |
---|---|---|
50 ms | linux > lld.MachO::weak-binding.s |
Event Timeline
LGTM
lld/MachO/SyntheticSections.cpp | ||
---|---|---|
429 | This is ridiculously nitty on my part, but if you write this instead, it'll get short-circuited. | |
lld/test/MachO/weak-header-flags.s | ||
16 | Nit: I'd prefer an --implicit-check-not MH_WEAK_DEFINES in the FileCheck command instead, to catch it both before or after the MH_BINDS_TO_WEAK (or you could also add the NOT check before as well). I recognize that readobj will probably print them in the order you're checking (and the above test would fail if that order changed anyway), so this is a purely hypothetical concern :) |
address comments
lld/MachO/SyntheticSections.cpp | ||
---|---|---|
429 | I know... I just hate that C++ doesn't support ||=. I'll change it :p | |
lld/test/MachO/weak-header-flags.s | ||
16 | I dislike how --implicit-check-not is placed far away from the other check statements, but putting it before and after the positive check here sounds good |
clang-tidy: warning: 'auto *defined' can be declared as 'const auto *defined' [llvm-qualified-auto]
not useful