Page MenuHomePhabricator

[AMDGPU, docs] Fix typos
ClosedPublic

Authored by RamNalamothu on Aug 21 2020, 4:28 AM.

Diff Detail

Event Timeline

RamNalamothu created this revision.Aug 21 2020, 4:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2020, 4:28 AM
RamNalamothu requested review of this revision.Aug 21 2020, 4:28 AM
Flakebi accepted this revision.Aug 21 2020, 9:28 AM
Flakebi added a subscriber: Flakebi.

Looks good, thanks!

Maybe give the commit a more meaningful title than ‘test commit access’ :)

This revision is now accepted and ready to land.Aug 21 2020, 9:28 AM
t-tye requested changes to this revision.Aug 21 2020, 10:14 AM
t-tye added inline comments.
llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst
115

I am not sure that it is possible with current DWARF to express information for *any* optimized AMD GPU code. So I think the original statement is accurate. This is not about improving, it is about getting to even work in the first place.

This revision now requires changes to proceed.Aug 21 2020, 10:14 AM
RamNalamothu added inline comments.Aug 24 2020, 12:40 AM
llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst
115

Got it. Thank you.

Update the title and address review comments.

Another attempt to update title. New to arcanist :)

t-tye accepted this revision.Aug 24 2020, 8:24 AM

LGTM

This revision is now accepted and ready to land.Aug 24 2020, 8:24 AM
RamNalamothu retitled this revision from [AMDGPU, docs] Test commit access to [AMDGPU, docs] Fix typos.Aug 24 2020, 11:17 AM
This revision was automatically updated to reflect the committed changes.