Page MenuHomePhabricator

RamNalamothu (Venkata Ramanaiah Nalamothu)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 25 2020, 6:50 PM (58 w, 6 d)

Recent Activity

Thu, Apr 1

RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

Rebase and ping

Thu, Apr 1, 5:40 AM · debug-info, Restricted Project

Tue, Mar 16

RamNalamothu committed rG43f2d269b383: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue (authored by RamNalamothu).
[AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue
Tue, Mar 16, 6:50 AM
RamNalamothu closed D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.
Tue, Mar 16, 6:50 AM · Restricted Project
RamNalamothu added a comment to D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.

Incorporated the suggestions. Thank you.

Tue, Mar 16, 4:01 AM · Restricted Project
RamNalamothu updated the diff for D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.

Address feedback as suggested.

Tue, Mar 16, 3:59 AM · Restricted Project
RamNalamothu updated the diff for D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.

Address review comments.

Tue, Mar 16, 2:59 AM · Restricted Project

Sun, Mar 14

RamNalamothu requested review of D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.
Sun, Mar 14, 10:22 PM · Restricted Project

Mar 9 2021

RamNalamothu added a comment to D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

I think I have addressed the feedback. Could you please take a look now?

Mar 9 2021, 1:21 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

Rebase onto ToT.

Mar 9 2021, 1:01 AM · debug-info, Restricted Project
RamNalamothu retitled D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo from [AMDGPU] Add SupportsDebugUnwindInformation to MCAsmInfo to [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.
Mar 9 2021, 12:56 AM · debug-info, Restricted Project

Mar 5 2021

RamNalamothu committed rG3998a8e79761: [AMDGPU] Do not attempt sgpr spills to vgpr, when it is disabled (authored by RamNalamothu).
[AMDGPU] Do not attempt sgpr spills to vgpr, when it is disabled
Mar 5 2021, 9:18 AM
RamNalamothu closed D98013: [AMDGPU] Do not attempt sgpr spills to vgpr, when it is disabled.
Mar 5 2021, 9:17 AM · Restricted Project
RamNalamothu requested review of D98013: [AMDGPU] Do not attempt sgpr spills to vgpr, when it is disabled.
Mar 5 2021, 12:26 AM · Restricted Project

Feb 12 2021

RamNalamothu updated the diff for D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs.

Rebase onto LLVM trunk and couple of bug fixes where we need to save FP due to CFI register spills but did not save it.

Feb 12 2021, 2:24 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76883: [AMDGPU] Implement CFI for CSR spills.

Rebase onto LLVM trunk.

Feb 12 2021, 2:19 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76882: [AMDGPU] Implement CFI for non-kernel functions.

Rebase onto LLVM trunk.

Feb 12 2021, 2:17 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76880: [AMDGPU] Emit entry function CFI.

Rebase onto LLVM trunk.

Feb 12 2021, 2:15 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase and ping.

Feb 12 2021, 2:13 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Rebase and extend the patch to cover https://reviews.llvm.org/rGf8122d35325d9a5d3db7d4c0d40bcdeae15bee5a.

Feb 12 2021, 2:10 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

Rebase and ping

Feb 12 2021, 2:06 AM · debug-info, Restricted Project

Jan 31 2021

RamNalamothu accepted D95768: [AMDGPU] Fix crash with sgpr spills to vgpr disabled.

LGTM

Jan 31 2021, 8:44 PM · Restricted Project

Jan 21 2021

RamNalamothu committed rGb6c3a59c3f55: [AMDGPU] Test case demonstrating issues with generation of .debug_frame (authored by RamNalamothu).
[AMDGPU] Test case demonstrating issues with generation of .debug_frame
Jan 21 2021, 6:09 PM
RamNalamothu closed D94801: [AMDGPU] Test case demonstrating issues with generation of .debug_frame.
Jan 21 2021, 6:09 PM · Restricted Project

Jan 15 2021

RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

How does it look now, with some renaming I did?

Jan 15 2021, 10:26 AM · debug-info, Restricted Project
RamNalamothu requested review of D94801: [AMDGPU] Test case demonstrating issues with generation of .debug_frame.
Jan 15 2021, 9:27 AM · Restricted Project

Dec 18 2020

RamNalamothu added a comment to D76519: [NFC] Refactor how CFI move sections are represented in AsmPrinter.

As a potential follow-up, I do want the CFIMoveTypes concept to be better documented and probably rename it if it does not convey the intended meaning to readers.

Dec 18 2020, 3:59 AM · Restricted Project

Dec 10 2020

RamNalamothu added a comment to D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

(I'm probably not the best person to review this - just chimed in on the patch structure/testing issues, but here are some naive questions)

I haven't touched the streamer side of AsmPrinter in a long time, but...
On PS4 we default to -fno-exceptions and while the section ends up named .eh_frame instead of .debug_frame the content is fine; we've had no complaints from our debugger folks. Aside from the introduction of the .cfi directives (which you do want), I'm not aware that there's any codegen consequence to this combination.
So, I'm not clear why a special streamer is really necessary.

A special streamer is a straight forward and minimal changes approach we could arrive at as a means to solve the following concerns observed with the current implementation.

  1. Today, with -fno-exceptions, the command line option --force-dwarf-frame-section of llc doesn't do what it should as per D67216 i.e. a .debug_frame is not generated

Does this change address (1)? Should there be a test for --force-dwarf-frame-section to demonstrate this fix? (what cases did D67216 address? that are distinct from this case that it misses)

Dec 10 2020, 8:47 AM · debug-info, Restricted Project

Oct 27 2020

RamNalamothu updated the diff for D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs.

Rebase onto LLVM master and address feedback

Oct 27 2020, 7:58 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76883: [AMDGPU] Implement CFI for CSR spills.

Rebase onto LLVM master and address feedback

Oct 27 2020, 7:56 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76882: [AMDGPU] Implement CFI for non-kernel functions.

Rebase onto LLVM master and address feedback

Oct 27 2020, 7:54 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76880: [AMDGPU] Emit entry function CFI.

Rebase onto LLVM master and address feedback

Oct 27 2020, 7:52 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76879: [AMDGPU] Begin emitting CFI for AMDGCN.

Rebase onto LLVM Master

Oct 27 2020, 7:49 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

Rebase onto LLVM Master

Oct 27 2020, 7:46 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase onto LLVM master

Oct 27 2020, 7:45 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Rebase on top of LLVM master

Oct 27 2020, 7:43 AM · debug-info, Restricted Project

Oct 20 2020

RamNalamothu committed rG89f7ccea6f64: [AMDGPU] Remove getAllVGPR32() which cannot handle Accum VGPRs properly (authored by RamNalamothu).
[AMDGPU] Remove getAllVGPR32() which cannot handle Accum VGPRs properly
Oct 20 2020, 10:46 AM
RamNalamothu closed D89806: [AMDGPU] Remove getAllVGPR32() which cannot handle Accum VGPRs properly.
Oct 20 2020, 10:45 AM · Restricted Project
RamNalamothu requested review of D89806: [AMDGPU] Remove getAllVGPR32() which cannot handle Accum VGPRs properly.
Oct 20 2020, 9:42 AM · Restricted Project
RamNalamothu added inline comments to D76879: [AMDGPU] Begin emitting CFI for AMDGCN.
Oct 20 2020, 1:51 AM · debug-info, Restricted Project

Sep 29 2020

RamNalamothu added a comment to D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

I haven't touched the streamer side of AsmPrinter in a long time, but...
On PS4 we default to -fno-exceptions and while the section ends up named .eh_frame instead of .debug_frame the content is fine; we've had no complaints from our debugger folks. Aside from the introduction of the .cfi directives (which you do want), I'm not aware that there's any codegen consequence to this combination.
So, I'm not clear why a special streamer is really necessary.

Sep 29 2020, 9:49 AM · debug-info, Restricted Project

Sep 10 2020

RamNalamothu added reviewers for D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs: greened, cameron.mcinally.
Sep 10 2020, 4:26 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs.

Rebase onto LLVM master. Tidy up code little bit and couple of fixes.
And also, handle cases where no free VGPR is available to spill into and we have to spill into memeory.

Sep 10 2020, 4:25 AM · debug-info, Restricted Project
RamNalamothu added reviewers for D76883: [AMDGPU] Implement CFI for CSR spills: greened, cameron.mcinally.
Sep 10 2020, 4:04 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76883: [AMDGPU] Implement CFI for CSR spills.

Rebase onto LLVM master

Sep 10 2020, 4:04 AM · debug-info, Restricted Project
RamNalamothu added reviewers for D76882: [AMDGPU] Implement CFI for non-kernel functions: greened, cameron.mcinally.
Sep 10 2020, 3:59 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76882: [AMDGPU] Implement CFI for non-kernel functions.

Rebase onto LLVM master

Sep 10 2020, 3:58 AM · debug-info, Restricted Project
RamNalamothu added reviewers for D76880: [AMDGPU] Emit entry function CFI: greened, cameron.mcinally.
Sep 10 2020, 3:55 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76880: [AMDGPU] Emit entry function CFI.

Rebase onto LLVM master

Sep 10 2020, 3:54 AM · debug-info, Restricted Project
RamNalamothu added reviewers for D76879: [AMDGPU] Begin emitting CFI for AMDGCN: greened, cameron.mcinally.
Sep 10 2020, 3:51 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76879: [AMDGPU] Begin emitting CFI for AMDGCN.

Rebase onto LLVM master

Sep 10 2020, 3:51 AM · debug-info, Restricted Project
RamNalamothu added reviewers for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging: greened, cameron.mcinally.
Sep 10 2020, 3:46 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase onto LLVM master

Sep 10 2020, 3:45 AM · debug-info, Restricted Project
RamNalamothu added reviewers for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo: greened, cameron.mcinally.
Sep 10 2020, 3:41 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

Rebase onto LLVM master

Sep 10 2020, 3:40 AM · debug-info, Restricted Project
RamNalamothu added reviewers for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging: greened, cameron.mcinally.
Sep 10 2020, 3:38 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Rebase onto LLVM master

Sep 10 2020, 3:36 AM · debug-info, Restricted Project

Sep 5 2020

RamNalamothu committed rGaff94ec0f4de: [AMDGPU] Remove the dead spill slots while spilling FP/BP to memory (authored by RamNalamothu).
[AMDGPU] Remove the dead spill slots while spilling FP/BP to memory
Sep 5 2020, 6:35 PM
RamNalamothu closed D87032: [AMDGPU] Remove the dead spill slots while spilling FP/BP to memory.
Sep 5 2020, 6:35 PM · Restricted Project

Sep 2 2020

RamNalamothu added inline comments to D87032: [AMDGPU] Remove the dead spill slots while spilling FP/BP to memory.
Sep 2 2020, 1:54 PM · Restricted Project
RamNalamothu updated the diff for D87032: [AMDGPU] Remove the dead spill slots while spilling FP/BP to memory.

Ah, wrong changset was committed in the previous update.

Sep 2 2020, 1:51 PM · Restricted Project
RamNalamothu updated the diff for D87032: [AMDGPU] Remove the dead spill slots while spilling FP/BP to memory.

Address review comments.

Sep 2 2020, 1:46 PM · Restricted Project
RamNalamothu updated the diff for D87032: [AMDGPU] Remove the dead spill slots while spilling FP/BP to memory.

Update a relevant test in 'callee-frame-setup.ll' for validating the patch.

Sep 2 2020, 8:56 AM · Restricted Project
RamNalamothu requested review of D87032: [AMDGPU] Remove the dead spill slots while spilling FP/BP to memory.
Sep 2 2020, 8:23 AM · Restricted Project

Aug 24 2020

RamNalamothu committed rGb9496efbb9eb: [AMDGPU, docs] Fix typos (authored by RamNalamothu).
[AMDGPU, docs] Fix typos
Aug 24 2020, 11:31 AM
RamNalamothu closed D86340: [AMDGPU, docs] Fix typos.
Aug 24 2020, 11:31 AM · Restricted Project
RamNalamothu retitled D86340: [AMDGPU, docs] Fix typos from [AMDGPU, docs] Test commit access to [AMDGPU, docs] Fix typos.
Aug 24 2020, 11:17 AM · Restricted Project
RamNalamothu updated the diff for D86340: [AMDGPU, docs] Fix typos.

Another attempt to update title. New to arcanist :)

Aug 24 2020, 2:17 AM · Restricted Project
RamNalamothu updated the diff for D86340: [AMDGPU, docs] Fix typos.

Update the title and address review comments.

Aug 24 2020, 1:32 AM · Restricted Project
RamNalamothu added inline comments to D86340: [AMDGPU, docs] Fix typos.
Aug 24 2020, 12:40 AM · Restricted Project

Aug 21 2020

RamNalamothu added reviewers for D86340: [AMDGPU, docs] Fix typos: t-tye, scott.linder.
Aug 21 2020, 4:29 AM · Restricted Project
RamNalamothu requested review of D86340: [AMDGPU, docs] Fix typos.
Aug 21 2020, 4:28 AM · Restricted Project

Aug 20 2020

RamNalamothu added reviewers for D86291: [AMDGPU] allSGPRSpillsAreDead() should use actual FP/BP frame indices: arsenm, scott.linder.
Aug 20 2020, 7:48 AM · Restricted Project
RamNalamothu requested review of D86291: [AMDGPU] allSGPRSpillsAreDead() should use actual FP/BP frame indices.
Aug 20 2020, 7:46 AM · Restricted Project

Jun 26 2020

RamNalamothu updated the diff for D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs.

Rebase

Jun 26 2020, 5:24 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76883: [AMDGPU] Implement CFI for CSR spills.

Rebase and update get{S,V}GPRSpillSaveOpcode (SIInstrInfo.cpp) as
per https://reviews.llvm.org/rG46579471fd2b9c00ba982325f53f30192cc5797f

Jun 26 2020, 5:24 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76882: [AMDGPU] Implement CFI for non-kernel functions.

Rebase

Jun 26 2020, 5:24 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76880: [AMDGPU] Emit entry function CFI.

Rebase

Jun 26 2020, 5:24 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76879: [AMDGPU] Begin emitting CFI for AMDGCN.

Rebase

Jun 26 2020, 4:54 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase

Jun 26 2020, 4:51 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

Rebase

Jun 26 2020, 4:50 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Rebase and update CFIProgram::parse (DWARFDebugFrame.cpp) changes as
per https://reviews.llvm.org/rG1e820e82b1438a52124512175a0e7c6f8d23e158

Jun 26 2020, 4:50 AM · debug-info, Restricted Project

Jun 11 2020

RamNalamothu updated the diff for D76883: [AMDGPU] Implement CFI for CSR spills.

Rebase

Jun 11 2020, 3:01 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs.

Rebase and fix position of spill for -amdgpu-spill-cfi-saved-regs

Jun 11 2020, 3:01 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D79878: [NFC] Move getAll{S,V}GPR{32,128} methods to SIFrameLowering.

Rebase

Jun 11 2020, 3:01 AM · Restricted Project
RamNalamothu updated the diff for D76882: [AMDGPU] Implement CFI for non-kernel functions.

Rebase and emit CFI for Base pointer

Jun 11 2020, 3:01 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76881: [AMDGPU] Skip CFIInstructions in SIInsertWaitcnts.

Rebase

Jun 11 2020, 3:01 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76880: [AMDGPU] Emit entry function CFI.

Rebase and add an MIR test

Jun 11 2020, 3:01 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76879: [AMDGPU] Begin emitting CFI for AMDGCN.

Rebase and update tests

Jun 11 2020, 3:01 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase

Jun 11 2020, 2:26 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

Rebase and address feedback

Jun 11 2020, 2:26 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Rebase and address feedback.

Jun 11 2020, 2:26 AM · debug-info, Restricted Project

May 20 2020

RamNalamothu added inline comments to D76880: [AMDGPU] Emit entry function CFI.
May 20 2020, 2:07 AM · debug-info, Restricted Project

May 19 2020

Herald added a reviewer for D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting.: MaskRay.
May 19 2020, 8:54 PM · debug-info, lld, Restricted Project

May 13 2020

RamNalamothu added inline comments to D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.
May 13 2020, 6:34 PM · debug-info, Restricted Project

May 12 2020

RamNalamothu added inline comments to D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.
May 12 2020, 7:56 PM · debug-info, Restricted Project
RamNalamothu added inline comments to D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.
May 12 2020, 7:24 PM · debug-info, Restricted Project

May 11 2020

RamNalamothu added inline comments to D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.
May 11 2020, 9:35 PM · debug-info, Restricted Project
RamNalamothu accepted D76879: [AMDGPU] Begin emitting CFI for AMDGCN.

LGTM

May 11 2020, 9:07 AM · debug-info, Restricted Project
RamNalamothu added a comment to D78778: [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.

@scott.linder is this not yet ready for review, as you have not added any reviewers?

May 11 2020, 6:56 AM · debug-info, Restricted Project

May 5 2020

RamNalamothu added inline comments to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.
May 5 2020, 6:58 AM · debug-info, Restricted Project