This is an archive of the discontinued LLVM Phabricator instance.

Paths

Refactor: Simplify boolean expressions in Hexagon target
ClosedPublic

Authored by LegalizeAdulthood on Mar 22 2015, 12:55 PM.

Reviewers

Summary

Simplify boolean expressions using true and false with clang-tidy

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean expressions in Hexagon target.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

Let me know if you don't have commit access.

This revision is now accepted and ready to land.Mar 23 2015, 8:47 AM

Could you commit this for me please? I do not have commit access. Thanks!

R232955

Path

Size

lib/

Target/

Hexagon/

5 lines

Show First 20 Lines • Show All 397 Lines • ▼ Show 20 Lines	static bool DoesModifyCalleeSavedReg(MachineInstr *MI,
}		}
return false;		return false;
}		}

// Returns true if an instruction can be promoted to .new predicate		// Returns true if an instruction can be promoted to .new predicate
// or new-value store.		// or new-value store.
bool HexagonPacketizerList::isNewifiable(MachineInstr* MI) {		bool HexagonPacketizerList::isNewifiable(MachineInstr* MI) {
const HexagonInstrInfo QII = (const HexagonInstrInfo ) TII;		const HexagonInstrInfo QII = (const HexagonInstrInfo ) TII;
if ( isCondInst(MI) \|\| QII->mayBeNewStore(MI))		return isCondInst(MI) \|\| QII->mayBeNewStore(MI);
return true;
else
return false;
}		}

bool HexagonPacketizerList::isCondInst (MachineInstr* MI) {		bool HexagonPacketizerList::isCondInst (MachineInstr* MI) {
const HexagonInstrInfo QII = (const HexagonInstrInfo ) TII;		const HexagonInstrInfo QII = (const HexagonInstrInfo ) TII;
const MCInstrDesc& TID = MI->getDesc();		const MCInstrDesc& TID = MI->getDesc();
// bug 5670: until that is fixed,		// bug 5670: until that is fixed,
// this portion is disabled.		// this portion is disabled.
if ( TID.isConditionalBranch() // && !IsRegisterJump(MI)) \|\|		if ( TID.isConditionalBranch() // && !IsRegisterJump(MI)) \|\|
▲ Show 20 Lines • Show All 1,000 Lines • Show Last 20 Lines