Page MenuHomePhabricator

Implement shift+tab for going back in lldb gui views
ClosedPublic

Authored by llunak on Sun, Aug 2, 4:26 AM.

Details

Summary

Add Shift+Tab -> back to complement the existing Tab -> forward. Also simplifies the forward code so that there's not to much code when adding code for back.

Diff Detail

Event Timeline

llunak created this revision.Sun, Aug 2, 4:26 AM
llunak requested review of this revision.Sun, Aug 2, 4:26 AM
clayborg accepted this revision.Tue, Aug 4, 4:02 PM

A few nits inlined.

lldb/source/Core/IOHandlerCursesGUI.cpp
696–699

Might be simpler as:

int start_idx = 0;
if (m_curr_active_window_idx != UINT32_MAX) {
718–721

Simpler?:

int start_idx = 0;
if (m_curr_active_window_idx != UINT32_MAX) {
This revision is now accepted and ready to land.Tue, Aug 4, 4:02 PM
This revision was automatically updated to reflect the committed changes.
llunak marked 2 inline comments as done.