Page MenuHomePhabricator

llunak (Luboš Luňák)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2017, 4:06 AM (138 w, 5 h)

Recent Activity

Wed, Aug 5

llunak committed rG4a8e4b5c7447: [lldb][gui] use names for color pairs, instead of magic numbers (authored by llunak).
[lldb][gui] use names for color pairs, instead of magic numbers
Wed, Aug 5, 11:59 PM
llunak committed rG14406ca01fd3: [lldb][gui] use syntax highlighting also in gui mode (authored by llunak).
[lldb][gui] use syntax highlighting also in gui mode
Wed, Aug 5, 11:59 PM
llunak closed D85286: [lldb][gui] use names for color pairs, instead of magic numbers.
Wed, Aug 5, 11:59 PM · Restricted Project
llunak closed D85145: Use syntax highlighting also in gui mode.
Wed, Aug 5, 11:59 PM · Restricted Project
llunak committed rGfc0e8fb7874a: [lldb][gui] truncate long lines/names if needed (authored by llunak).
[lldb][gui] truncate long lines/names if needed
Wed, Aug 5, 11:41 PM
llunak closed D85123: Truncate long lines/names if needed in lldb gui.
Wed, Aug 5, 11:41 PM · Restricted Project
llunak requested review of D85290: [lldb][gui] use left/right in the source view to scroll.
Wed, Aug 5, 4:27 AM
llunak committed rG188187f062a5: [lldb] expect TestGuiBasicDebug.py failure on aarch64 (authored by llunak).
[lldb] expect TestGuiBasicDebug.py failure on aarch64
Wed, Aug 5, 3:22 AM
llunak added a reverting change for rG21f142ce1df1: [lldb] temporary commit to see why a test is failing only on lldb-aarch64-ubuntu: rG138281904ba0: Revert "[lldb] temporary commit to see why a test is failing only on lldb….
Wed, Aug 5, 3:02 AM
llunak committed rG138281904ba0: Revert "[lldb] temporary commit to see why a test is failing only on lldb… (authored by llunak).
Revert "[lldb] temporary commit to see why a test is failing only on lldb…
Wed, Aug 5, 3:02 AM
llunak committed rG21f142ce1df1: [lldb] temporary commit to see why a test is failing only on lldb-aarch64-ubuntu (authored by llunak).
[lldb] temporary commit to see why a test is failing only on lldb-aarch64-ubuntu
Wed, Aug 5, 2:55 AM
llunak updated the diff for D85286: [lldb][gui] use names for color pairs, instead of magic numbers.

Change also SetBackground() calls.

Wed, Aug 5, 2:49 AM · Restricted Project
llunak added inline comments to D85145: Use syntax highlighting also in gui mode.
Wed, Aug 5, 2:15 AM · Restricted Project
llunak requested review of D85286: [lldb][gui] use names for color pairs, instead of magic numbers.
Wed, Aug 5, 2:11 AM · Restricted Project
llunak updated the diff for D85123: Truncate long lines/names if needed in lldb gui.

Use SteamString.

Wed, Aug 5, 1:14 AM · Restricted Project
llunak committed rGdb828aba55ac: [lldb][gui] add a test for 'b' (toggle breakpoint) (authored by llunak).
[lldb][gui] add a test for 'b' (toggle breakpoint)
Wed, Aug 5, 12:52 AM
llunak committed rGc7be982c836c: [lldb][gui] move TestGuiBasicDebug.py to lldb/test and update it (authored by llunak).
[lldb][gui] move TestGuiBasicDebug.py to lldb/test and update it
Wed, Aug 5, 12:52 AM
llunak committed rGd6868d9ca1db: [lldb][gui] implement breakpoint removal on breakpoint toggling (authored by llunak).
[lldb][gui] implement breakpoint removal on breakpoint toggling
Wed, Aug 5, 12:52 AM
llunak committed rG7a63dc534eb8: [lldb][gui] implement shift+tab for going back in views (authored by llunak).
[lldb][gui] implement shift+tab for going back in views
Wed, Aug 5, 12:52 AM
llunak closed D85107: Add a test for 'b' (toggle breakpoint).
Wed, Aug 5, 12:52 AM · Restricted Project
llunak committed rG2f1b24b70c6c: [lldb][gui] implement TerminalSizeChanged() (authored by llunak).
[lldb][gui] implement TerminalSizeChanged()
Wed, Aug 5, 12:52 AM
llunak closed D85106: Move TestGuiBasicDebug.py to lldb/test and update it.
Wed, Aug 5, 12:51 AM · Restricted Project
llunak closed D85098: Implement breakpoint removal on breakpoint toggling in lldb gui.
Wed, Aug 5, 12:51 AM · Restricted Project
llunak committed rGc952ec15d388: [lldb] fix building with panel.h being in /usr/include/ncurses/ (authored by llunak).
[lldb] fix building with panel.h being in /usr/include/ncurses/
Wed, Aug 5, 12:51 AM
llunak closed D85089: Implement shift+tab for going back in lldb gui views.
Wed, Aug 5, 12:51 AM · Restricted Project
llunak closed D85088: Implement TerminalSizeChanged() for lldb ncurses GUI.
Wed, Aug 5, 12:51 AM · Restricted Project
llunak closed D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/.
Wed, Aug 5, 12:51 AM · Restricted Project
llunak added a comment to D85106: Move TestGuiBasicDebug.py to lldb/test and update it.

I personally don't particularly care where the tests are, I just wanted all the gui tests to be together to make it simpler to run them all.

Wed, Aug 5, 12:47 AM · Restricted Project

Tue, Aug 4

llunak requested review of D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/.
Tue, Aug 4, 9:42 AM · Restricted Project
llunak updated the diff for D85145: Use syntax highlighting also in gui mode.

Updated according to comments.

Tue, Aug 4, 4:44 AM · Restricted Project
llunak added a comment to D85145: Use syntax highlighting also in gui mode.

I wonder if there is a reasonable way to test this. From what I understand these attributes aren't in any output buffer that we could expect (e.g., with a pexpect test).

Tue, Aug 4, 4:12 AM · Restricted Project
llunak committed rGdaa1c6d9d126: [lldb] fix typo (authored by llunak).
[lldb] fix typo
Tue, Aug 4, 3:07 AM

Mon, Aug 3

llunak added a comment to D85145: Use syntax highlighting also in gui mode.

Btw, the highlighter supports any kind of delimiter string when 'highlighting' source. So you could add a parameter for a custom highlighter too and then pass a more convenient highlighter 'style' in to make the parsing simpler. See the only call MakeVimStyle (which generates the style that adds the color escapes) and the HighlighterStyle where you can set any kind of delimiter.

Mon, Aug 3, 1:33 PM · Restricted Project
llunak requested review of D85145: Use syntax highlighting also in gui mode.
Mon, Aug 3, 11:28 AM · Restricted Project
llunak updated the diff for D85123: Truncate long lines/names if needed in lldb gui.

Handle properly also the "<<< Thread 1: breakpoint 1.1" marker.

Mon, Aug 3, 6:41 AM · Restricted Project
llunak requested review of D85123: Truncate long lines/names if needed in lldb gui.
Mon, Aug 3, 4:52 AM · Restricted Project
llunak updated the diff for D85107: Add a test for 'b' (toggle breakpoint).

Removed use of curses python module, lldbexpect hardcodes TERM=vt100, so the escape sequence should be actually hardcoded too. The previous version didn't work e.g. in Linux console.

Mon, Aug 3, 2:33 AM · Restricted Project
llunak committed rG18d4069503e7: fix lldb test on lib64 systems (authored by llunak).
fix lldb test on lib64 systems
Mon, Aug 3, 2:19 AM
llunak closed D85096: Fix lldb test on lib64 systems.
Mon, Aug 3, 2:19 AM · Restricted Project

Sun, Aug 2

llunak requested review of D85107: Add a test for 'b' (toggle breakpoint).
Sun, Aug 2, 11:39 PM · Restricted Project
llunak requested review of D85106: Move TestGuiBasicDebug.py to lldb/test and update it.
Sun, Aug 2, 11:38 PM · Restricted Project
llunak requested review of D85098: Implement breakpoint removal on breakpoint toggling in lldb gui.
Sun, Aug 2, 1:07 PM · Restricted Project
llunak requested review of D85096: Fix lldb test on lib64 systems.
Sun, Aug 2, 10:23 AM · Restricted Project
llunak abandoned D85090: Fix lldb build with -DLLVM_ENABLE_MODULES=On.

Including <cstdint> is probably more correct - the clang warning points to the Flags module as one module that defines the typedef, but because this is probably being tested against an unmodularized standard library, the module chosen is somewhat arbitrary/not directly relevant to the issue (it's just one module that itself happens to include <cstdint> or some other standard header that pulls in a definition of uint16_t )

Sun, Aug 2, 10:21 AM · Restricted Project
llunak added a comment to D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC.

The DWARF in the source file appears to be broken, the test fails for me on openSUSE 15.2 x86_64, with errors about DIE references outside of its CU. It fails even if I try to manually compile and debug the file, with Clang git or 9, GCC 7.5 or 9, LLDB git or 9, GDB 9.2.

Sun, Aug 2, 9:11 AM · Restricted Project
llunak updated the summary of D85090: Fix lldb build with -DLLVM_ENABLE_MODULES=On.
Sun, Aug 2, 4:31 AM · Restricted Project
llunak requested review of D85090: Fix lldb build with -DLLVM_ENABLE_MODULES=On.
Sun, Aug 2, 4:31 AM · Restricted Project
llunak requested review of D85089: Implement shift+tab for going back in lldb gui views.
Sun, Aug 2, 4:26 AM · Restricted Project
llunak requested review of D85088: Implement TerminalSizeChanged() for lldb ncurses GUI.
Sun, Aug 2, 4:24 AM · Restricted Project

Fri, Jul 31

llunak committed rG77d5a63c191c: [lldb] report an error if a CLI option lacks an argument (authored by llunak).
[lldb] report an error if a CLI option lacks an argument
Fri, Jul 31, 1:03 PM
llunak committed rG8739445e3221: [lldb] force full gui redraw on Ctrl+L (authored by llunak).
[lldb] force full gui redraw on Ctrl+L
Fri, Jul 31, 1:03 PM
llunak closed D84955: Report an error if a CLI option lacks an argument.
Fri, Jul 31, 1:03 PM · Restricted Project
llunak closed D84972: Force full gui redraw on Ctrl+L.
Fri, Jul 31, 1:03 PM · Restricted Project
llunak updated the diff for D84955: Report an error if a CLI option lacks an argument.

Adjusted according to the comments.

Fri, Jul 31, 6:15 AM · Restricted Project

Thu, Jul 30

llunak requested review of D84972: Force full gui redraw on Ctrl+L.
Thu, Jul 30, 12:35 PM · Restricted Project
llunak added a reviewer for D84955: Report an error if a CLI option lacks an argument: Restricted Project.
Thu, Jul 30, 10:50 AM · Restricted Project
llunak updated subscribers of D84955: Report an error if a CLI option lacks an argument.
Thu, Jul 30, 10:50 AM · Restricted Project
llunak requested review of D84955: Report an error if a CLI option lacks an argument.
Thu, Jul 30, 10:50 AM · Restricted Project

Wed, Jul 29

llunak committed rG13978643b678: [lldb] implement 'up' and 'down' shortcuts in lldb gui (authored by llunak).
[lldb] implement 'up' and 'down' shortcuts in lldb gui
Wed, Jul 29, 1:31 PM
llunak committed rG336c7029ef3b: [lldb] change shortcut for 'step out' from 'o' to 'f' (authored by llunak).
[lldb] change shortcut for 'step out' from 'o' to 'f'
Wed, Jul 29, 1:31 PM
llunak committed rG47d2c7cd5db4: [lldb] remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts (authored by llunak).
[lldb] remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts
Wed, Jul 29, 1:31 PM
llunak closed D68541: Implement 'up' and 'down' shortcuts in lldb gui.
Wed, Jul 29, 1:31 PM · Restricted Project
llunak closed D68909: change shortcut for 'step out' from 'o' to 'f'.
Wed, Jul 29, 1:30 PM · Restricted Project
llunak closed D68908: remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts.
Wed, Jul 29, 1:30 PM · Restricted Project
llunak added inline comments to D68908: remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts.
Wed, Jul 29, 12:44 PM · Restricted Project
llunak updated the diff for D68909: change shortcut for 'step out' from 'o' to 'f'.

Updated for current git.

Wed, Jul 29, 12:40 PM · Restricted Project
llunak updated the diff for D68908: remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts.

Updated for current git, and clang-format-ed.

Wed, Jul 29, 12:39 PM · Restricted Project
llunak updated the diff for D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Updated for current git, and clang-format-ed.

Wed, Jul 29, 12:38 PM · Restricted Project
llunak added a comment to D68908: remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts.

If removing 'd' was only to make it available for "up" and "down" in https://reviews.llvm.org/D68541, then maybe we should switch 'D' to "detach and let run? Or is that what we did, but the comment on line 4331 is now out of date?

Wed, Jul 29, 12:25 PM · Restricted Project
llunak added a comment to D68541: Implement 'up' and 'down' shortcuts in lldb gui.

My usual experience with Clang submissions is that I have to be really persistent to get a reaction, let alone an approval, so I assumed it was the same here and I didn't feel like pushing this that much. I'll update the patches to match current git and have a look at the review that still has questions.

Wed, Jul 29, 12:17 PM · Restricted Project

Wed, Jul 22

llunak committed rG54eea6127c4d: add -fpch-codegen/debuginfo mapping to -fmodules-codegen/debuginfo (authored by llunak).
add -fpch-codegen/debuginfo mapping to -fmodules-codegen/debuginfo
Wed, Jul 22, 1:23 AM
llunak committed rG3895466e2c33: accept 'clang++ -c a.pch -o a.o' to create PCH's object file (authored by llunak).
accept 'clang++ -c a.pch -o a.o' to create PCH's object file
Wed, Jul 22, 1:23 AM
llunak closed D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.
Wed, Jul 22, 1:23 AM · Restricted Project
llunak closed D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.
Wed, Jul 22, 1:23 AM · Restricted Project

Tue, Jul 21

llunak updated the diff for D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.

Updated driver test to just create a dummy file for PCH.

Tue, Jul 21, 1:30 PM · Restricted Project
llunak added a comment to D83652: Merge some of the PCH object support with modular codegen.

@llunak Would you be able to test this on anything you've got?

Tue, Jul 21, 1:19 AM · Restricted Project
llunak added inline comments to D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.
Tue, Jul 21, 12:42 AM · Restricted Project

Sat, Jul 18

llunak updated the diff for D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.

Used OptInFFlag and adapted to changes in D83716.

Sat, Jul 18, 7:00 AM · Restricted Project
llunak updated the diff for D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.

Moved driver test under test/Driver/.

Sat, Jul 18, 6:59 AM · Restricted Project

Wed, Jul 15

llunak added a comment to D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.

By "secret" flags I mean prefixing them with -Xclang. But I guess that's how this situation will turn out. If this one and D83623 don't make it into Clang11, then people will need to use the -Xclang ones, and then these new ones don't make much sense, because who'll support one set of flags now and implement an optional new set of flags half a year later merely to have a slightly nicer spelling of the flags.

Wed, Jul 15, 3:49 PM · Restricted Project
llunak added inline comments to D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.
Wed, Jul 15, 12:15 PM · Restricted Project
llunak added inline comments to D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.
Wed, Jul 15, 11:19 AM · Restricted Project

Tue, Jul 14

llunak added a comment to D83652: Merge some of the PCH object support with modular codegen.

Not quite - it's intended to implement the D48426 functionality using an implementation strategy that is closer to modular code generation. Removing the need for the module flag, using the MODULAR_CODEGEN_DECLS list, etc. But only putting the dllexported entities in there (when using only building-pch-with-obj without -fmodules-codegen).

Tue, Jul 14, 10:10 PM · Restricted Project
llunak added inline comments to D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.
Tue, Jul 14, 10:00 PM · Restricted Project
llunak committed rGd1ca9960bc19: document -fpch-instantiate-templates in release notes (authored by llunak).
document -fpch-instantiate-templates in release notes
Tue, Jul 14, 2:19 PM
llunak closed D83622: document -fpch-instantiate-templates in release notes.
Tue, Jul 14, 2:19 PM · Restricted Project

Mon, Jul 13

llunak updated the diff for D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.

Only add -fpch-* as driver options that map to -fmodules-*.
Change caveats in the documentation to extra notes at the end.

Mon, Jul 13, 10:38 PM · Restricted Project
llunak updated the diff for D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.

Adjusted test/PCH/codegen.cpp to use/test the change (not much point in testing it without codegen, as in that case the shared object will be empty).

Mon, Jul 13, 10:34 PM · Restricted Project
llunak added inline comments to D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.
Mon, Jul 13, 2:20 PM · Restricted Project
llunak added a comment to D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.

This is tested in D83623 (I'd prefer not to split the changes to the test to reflect both the state before and after D83623).

Mon, Jul 13, 2:08 PM · Restricted Project
llunak updated the diff for D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.

Update also the -cc1 test to reflect D83716.

Mon, Jul 13, 2:06 PM · Restricted Project
llunak updated the diff for D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.

Updated to include change from D83716 (including testing it).

Mon, Jul 13, 1:51 PM · Restricted Project
llunak added a comment to D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.

I see. I had no idea PCM's worked like that.
At D83716 I've posted a patch that allows the same for PCH's.
I'll update this patch to reflect that change (since "Loc.F->Kind == ModuleKind::MK_MainFile" is true with this approach, -building-pch-with-obj is not needed).

Mon, Jul 13, 1:37 PM · Restricted Project
llunak created D83716: Accept 'clang++ -c a.pch -o a.o' to create PCH's object file.
Mon, Jul 13, 1:35 PM · Restricted Project
llunak added a comment to D83652: Merge some of the PCH object support with modular codegen.

The patch is incomplete, isn't it? It removes DeclIsFromPCHWithObjectFile(), but it's still called from ASTContext::DeclMustBeEmitted(). The description also mentions updating of the pch-codegen test, but that's not included.

Mon, Jul 13, 1:44 AM · Restricted Project

Sat, Jul 11

llunak added inline comments to D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.
Sat, Jul 11, 2:03 PM · Restricted Project
llunak added inline comments to D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.
Sat, Jul 11, 11:33 AM · Restricted Project
llunak added inline comments to D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.
Sat, Jul 11, 10:17 AM · Restricted Project
llunak created D83623: add -fpch-codegen/debuginfo options mapping to -fmodules-codegen/debuginfo.
Sat, Jul 11, 6:44 AM · Restricted Project
llunak created D83622: document -fpch-instantiate-templates in release notes.
Sat, Jul 11, 6:42 AM · Restricted Project