Page MenuHomePhabricator

[OpenMP] Ensure testing for versions 4.5 and default - Part 1
ClosedPublic

Authored by saiislam on Jul 29 2020, 7:02 AM.

Details

Summary

Many OpenMP Clang tests do not RUN for version 4.5 and the default
version. This first patch in the series only handles test cases
which do not require any modifications in the CHECK lines after
adding RUN lines for default version.

Diff Detail

Event Timeline

saiislam created this revision.Jul 29 2020, 7:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2020, 7:02 AM
saiislam requested review of this revision.Jul 29 2020, 7:02 AM

I'm not sure if this is profitable. All these changes increase the time of the test execution significantly in many cases while execution goes the same control paths. Some smart changes are required, only for things changed from version to version.

saiislam updated this revision to Diff 282678.Aug 3 2020, 10:45 AM

Removed redundant testing for version 5.0 with its version string.

saiislam retitled this revision from [OpenMP] Ensure testing for versions 4.5, 5.0, and default - Part 1 to [OpenMP] Ensure testing for versions 4.5 and default - Part 1.Aug 3 2020, 10:46 AM
saiislam edited the summary of this revision. (Show Details)

I think this is good. Let's see if there are objections

Next two (independent) parts are: D85150 and D85214. More to come.

Ping for this (part-1), D85150 (part-2), and D85214 (part-3).

This revision is now accepted and ready to land.Aug 11 2020, 8:04 AM

Time for check-clang has increased from ~51 sec to ~107 sec after this patch.
Putting it here before committing/closing the review.