This is an archive of the discontinued LLVM Phabricator instance.

[VE] Change calling convention to follow ABI
ClosedPublic

Authored by kaz7 on Jul 25 2020, 12:17 AM.

Details

Summary

Change to expand all arguments and return values to i64 to follow ABI.
Update regression tests also.

Diff Detail

Event Timeline

kaz7 created this revision.Jul 25 2020, 12:17 AM

Nit. LGTM otherwise.

llvm/lib/Target/VE/VEISelLowering.cpp
214

suggestion: "no need for adjustment"

kaz7 planned changes to this revision.Jul 31 2020, 2:30 AM
kaz7 marked an inline comment as done.

Thank you for your time to review this. I'll update code soon after regression test.

kaz7 updated this revision to Diff 282171.Jul 31 2020, 3:05 AM

Update and rebase

simoll accepted this revision.Jul 31 2020, 7:47 AM
This revision is now accepted and ready to land.Jul 31 2020, 7:47 AM
This revision was landed with ongoing or failed builds.Jul 31 2020, 6:09 PM
This revision was automatically updated to reflect the committed changes.