Page MenuHomePhabricator

[InstCombine] Disable branch predicate canonicalization by default
AbandonedPublic

Authored by yrouban on Jul 24 2020, 12:26 AM.

Details

Summary

Disabling the branch predicate canonicalization in InstCombine might affect many users. This transform is expected to be done by SimplifyCFG (D84492, D84491).
This one line patch allows a simple revert and further investigation for any found issues.
In future this transformation with its flag should be removed from InstCombine.

Diff Detail

Event Timeline

yrouban created this revision.Jul 24 2020, 12:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2020, 12:26 AM
lebedev.ri requested changes to this revision.Aug 5 2020, 4:05 AM

Abandon now that D84763 has resolved the base problem?

This revision now requires changes to proceed.Aug 5 2020, 4:05 AM
yrouban abandoned this revision.Aug 13 2020, 8:53 AM