Page MenuHomePhabricator

[SimplifyCFG] Enable branch predicate canonicalization by default
AbandonedPublic

Authored by yrouban on Jul 24 2020, 12:06 AM.

Details

Summary

The introduction of the branch predicate canonicalization in SimplifyCFG (D84491) might affect many users.
This patch allows a simple revert and further investigation for any found issues.

Diff Detail

Event Timeline

yrouban created this revision.Jul 24 2020, 12:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2020, 12:06 AM

Would it make sense to enable the canonicalization in SimplifyCFG and disable the one in InstCombine as a single patch?

lebedev.ri requested changes to this revision.Aug 5 2020, 4:05 AM

Abandon now that D84763 has resolved the base problem?

This revision now requires changes to proceed.Aug 5 2020, 4:05 AM
yrouban abandoned this revision.Aug 13 2020, 8:52 AM