This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPSr6] Implement BALC and BC instructions
ClosedPublic

Authored by jkolek on Mar 17 2015, 11:54 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

jkolek updated this revision to Diff 22113.Mar 17 2015, 11:54 AM
jkolek retitled this revision from to [mips][microMIPSr6] Implement BALC and BC instructions.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: zoran.jovanovic, dsanders.
jkolek added subscribers: Unknown Object (MLST), petarj.
jkolek updated this revision to Diff 22790.Mar 27 2015, 6:10 AM
jkolek updated this revision to Diff 23164.Apr 2 2015, 10:03 AM
dsanders accepted this revision.Apr 10 2015, 9:01 AM
dsanders edited edge metadata.

Could you add a disassembler test too?

LGTM with the disassembler test.

This revision is now accepted and ready to land.Apr 10 2015, 9:01 AM

Initial microMIPSr6 disassembler support is in separate patch, and it requires auto generated DecoderTableMicroMips32r632, which is not generated until some of the instructions exists. These instruction are the first microMIPSr6 instructions implemented, so after this patch the patch for microMIPSr6 disassembler support (http://reviews.llvm.org/D8490) will be committed and therefore the BALC and BC disassembler tests with it.

This revision was automatically updated to reflect the committed changes.

Initial microMIPSr6 disassembler support is in separate patch, and it requires auto generated DecoderTableMicroMips32r632, which is not generated until some of the instructions exists. These instruction are the first microMIPSr6 instructions implemented, so after this patch the patch for microMIPSr6 disassembler support (http://reviews.llvm.org/D8490) will be committed and therefore the BALC and BC disassembler tests with it.

That sounds good to me. Thanks