This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPSr6] Implement initial subtarget support
ClosedPublic

Authored by jkolek on Mar 17 2015, 11:48 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

jkolek updated this revision to Diff 22110.Mar 17 2015, 11:48 AM
jkolek retitled this revision from to [mips][microMIPSr6] Implement initial support.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: zoran.jovanovic, dsanders.
jkolek added subscribers: Unknown Object (MLST), petarj.
jkolek retitled this revision from [mips][microMIPSr6] Implement initial support to [mips][microMIPSr6] Implement initial subtarget support.Mar 17 2015, 12:03 PM
jkolek updated this revision to Diff 22589.Mar 24 2015, 12:00 PM
jkolek updated this revision to Diff 22796.Mar 27 2015, 7:10 AM
dsanders accepted this revision.Apr 1 2015, 11:38 AM
dsanders edited edge metadata.

LGTM with a couple nits.

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
134 ↗(On Diff #22796)

Do we need to check both here? I'd expect isMicroMips(STI) to be true for all revisions of microMIPS like the way hasMips32() is true when Mips32r6() is true.

lib/Target/Mips/MipsInstrInfo.td
186 ↗(On Diff #22796)

Nit: indentation

This revision is now accepted and ready to land.Apr 1 2015, 11:38 AM
jkolek updated this revision to Diff 23158.Apr 2 2015, 9:46 AM
jkolek edited edge metadata.

In this patch the feature FeatureMicroMips32r6 is removed, isMicroMips(STI) is true for both mips32r2 and mips32r6. The type of microMIPS is determined according to processor which can be mips32r2 or mips32r6.

jkolek updated this revision to Diff 24007.Apr 20 2015, 3:45 AM
zoran.jovanovic accepted this revision.Apr 20 2015, 4:44 AM
zoran.jovanovic edited edge metadata.

LGTM.

This revision was automatically updated to reflect the committed changes.