This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Add debug and stat counters to assume queries and assume builder
ClosedPublic

Authored by Tyker on Jul 9 2020, 1:40 PM.

Details

Summary

Add debug counter and stats counter to assume queries and assume builder
here is the collected stats on a build of check-llvm + check-clang.

"assume-builder.NumAssumeBuilt": 2720879,
"assume-builder.NumAssumesMerged": 761396,
"assume-builder.NumAssumesRemoved": 1576212,
"assume-builder.NumBundlesInAssumes": 6518809,
"assume-queries.NumAssumeQueries": 85566380,
"assume-queries.NumUsefullAssumeQueries": 2727360,

the NumUsefullAssumeQueries stat is actually pessimistic because in a few places queries
ask to keep providing information to try to get better information. and this isn't counted
as a usefull query evem tho it can be usefull

Diff Detail

Event Timeline

Tyker created this revision.Jul 9 2020, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2020, 1:40 PM
Tyker updated this revision to Diff 276831.Jul 9 2020, 2:00 PM

Fixed formating

jdoerfert accepted this revision.Jul 10 2020, 4:11 PM

Nice. LGTM, some nits to be fixed below.

llvm/lib/Analysis/AssumeBundleQueries.cpp
9

Style: Is usually below the includes.

173

Style: Use pre-increments everywhere.

185

Same

200

Same

llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
9

Same.

241

Same.

352

Same.

This revision is now accepted and ready to land.Jul 10 2020, 4:11 PM
This revision was automatically updated to reflect the committed changes.