Page MenuHomePhabricator

Fix SO entry is main executable detection on android
ClosedPublic

Authored by tberghammer on Mar 12 2015, 9:23 AM.

Details

Summary

Fix SO entry is main executable detection on android

  • On Android (at least on platfrom-21 x86) the dynamic linker reports the executable with its full path
  • Use the platform path of the executable when storing it into the cache (used to identify the SO entry for the executable) as this is the path what will be reported by the dynamic linker. If the platform path isn't set (local debugging) then it falls back to the normal file path.

Diff Detail

Event Timeline

tberghammer retitled this revision from to Fix SO entry is main executable detection on android.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added reviewers: clayborg, sas, ovyalov.
tberghammer added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Mar 12 2015, 9:46 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Mar 12 2015, 9:46 AM
ovyalov added inline comments.Mar 12 2015, 10:32 AM
source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
298

return entry.path.empty(); ?

tberghammer edited edge metadata.

Fix bug spotted in review

source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
298

Nice catch

ovyalov accepted this revision.Mar 12 2015, 10:45 AM
ovyalov edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.