Page MenuHomePhabricator

Fix missing data in GetProcessInfo on linux
ClosedPublic

Authored by tberghammer on Mar 12 2015, 7:53 AM.

Details

Summary

Fix missing data in GetProcessInfo on linux

Fill in the missing part of the architecture in GetProcessInfo from the HostArchitecture (e.g. Environment).

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Fix missing data in GetProcessInfo on linux.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: Unknown Object (MLST).
ovyalov accepted this revision.Mar 12 2015, 8:33 AM
ovyalov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 12 2015, 8:33 AM

Should ProcessInfo.GetArchitecture be const like Target?

http://reviews.llvm.org/D8287

Should ProcessInfo.GetArchitecture be const like Target?

http://reviews.llvm.org/D8287

ProcessInfo.SetArchitecture don't have any logic inside it what would make it necessary.
It is possible to make it const (remove the non const version) but it would require some effort as it is used as non-const several places in the code and a simple rewrite would imply a small performance penalty also (doesn't matter here, but can matter in other places).

This revision was automatically updated to reflect the committed changes.