Page MenuHomePhabricator

Remove non const version of GetArchitecture from Target.h
ClosedPublic

Authored by tberghammer on Mar 12 2015, 5:58 AM.

Details

Reviewers
clayborg
Summary

Remove non const version of GetArchitecture from Target.h

The architecture of a target should be updated only by the SetArchitecture method so the target can correctly manage its modules.

Change suggested in D8057

Diff Detail

Event Timeline

tberghammer retitled this revision from to Remove non const version of GetArchitecture from Target.h.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Mar 12 2015, 9:42 AM
clayborg edited edge metadata.

Are you still going to be making the other patch that involved Target::MergeArchitecture()?

This patch looks good, but I hope we still make the other patch because I don't want more than one location in the code doing architecture merging for Targets.

This revision is now accepted and ready to land.Mar 12 2015, 9:42 AM

Yes, I plan to commit in both tomorrow (if the git repository start working again)

tberghammer closed this revision.Mar 13 2015, 3:37 AM

Committed as r232152