This is an archive of the discontinued LLVM Phabricator instance.

Update LangRef now that a DataLayout is mandatory.
ClosedPublic

Authored by mehdi_amini on Mar 10 2015, 2:27 PM.

Diff Detail

Event Timeline

mehdi_amini retitled this revision from to Update LangRef now that a DataLayout is mandatory..
mehdi_amini updated this object.
mehdi_amini edited the test plan for this revision. (Show Details)
mehdi_amini added a reviewer: echristo.
mehdi_amini added a subscriber: Unknown Object (MLST).
rafael accepted this revision.Mar 12 2015, 3:44 PM
rafael added a reviewer: rafael.
rafael added a subscriber: rafael.

Nice :-)

This revision is now accepted and ready to land.Mar 12 2015, 3:44 PM
echristo edited edge metadata.Mar 12 2015, 3:46 PM

Couple of small inline comments.

docs/LangRef.rst
1531

Can you specify what you mean by specifications here?

1532

"optimization"

mehdi_amini added inline comments.Mar 12 2015, 4:06 PM
docs/LangRef.rst
1531

I reused the vocabulary of the previous paragraphs in this section:

target datalayout = "layout specification"

The *layout specification* consists of a list of specifications
separated by the minus sign character ('-'). Each specification starts
with a letter and may include other information after the letter to
define some aspect of the data layout. The specifications accepted are
as follows:

mehdi_amini closed this revision.Mar 14 2015, 3:06 PM